unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ivan Sokolov <ivan-p-sokolov@ya.ru>
Cc: 64531@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#64531: [PATCH v2] Add new command vc-dir-copy-filename-as-kill
Date: Sun, 20 Aug 2023 09:20:01 +0300	[thread overview]
Message-ID: <83bkf2xmjy.fsf@gnu.org> (raw)
In-Reply-To: <87sf8eeie7.fsf@ya.ru> (message from Ivan Sokolov on Sun, 20 Aug 2023 02:12:32 +0300)

> From: Ivan Sokolov <ivan-p-sokolov@ya.ru>
> Cc: Dmitry Gutov <dgutov@yandex.ru>,  64531@debbugs.gnu.org
> Date: Sun, 20 Aug 2023 02:12:32 +0300
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Ivan Sokolov <ivan-p-sokolov@ya.ru>
> >> Cc: 64531@debbugs.gnu.org
> >> Date: Tue, 08 Aug 2023 16:44:56 +0300
> >> 
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> 
> >> > However, new commands should be called out in NEWS, and commands that
> >> > are important enough should also be mentioned in the user manual.
> >> 
> >> Added entry in NEWS, but not in the user manual, there is no such for
> >> vc-dir afaik.
> >> 
> >> >> +(defun vc-dir-copy-filename-as-kill (&optional absolutep)
> >> >> +  "Copy names of marked files (or file under cursor) into the kill ring.
> >> >
> >> > This sentence is too general: it doesn't mention VC Dir, although
> >> > AFAIU it is specific to vc-dir.
> >> 
> >> Fixed.
> >
> > Dmitry, is this good to go in?
> >
> > I still think it should be mention in the Emacs user manual, where we
> > document vc-dir.
> 
> Hi, Eli!
> 
> I am working on the 3rd version of the patch with all the necessary
> documentation and changes to the command which I will explain in the
> cover letter.  Not sure when I'll finish it though.

Good to hear, and TIA.

There's no rush, so take your time.  (I will ping again if it takes
too long IMO ;-)





  reply	other threads:[~2023-08-20  6:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-08  7:51 bug#64531: [PATCH] Add new command vc-dir-copy-filename-as-kill Ivan Sokolov
2023-07-08  9:25 ` Eli Zaretskii
2023-08-08 13:44   ` bug#64531: [PATCH v2] " Ivan Sokolov
2023-08-08 13:56     ` Eli Zaretskii
2023-08-19  8:06     ` Eli Zaretskii
2023-08-19 23:12       ` Ivan Sokolov
2023-08-20  6:20         ` Eli Zaretskii [this message]
2023-08-19 23:33       ` Dmitry Gutov
2023-08-20  6:26         ` Eli Zaretskii
2023-08-20 10:26           ` Dmitry Gutov
2023-09-04 20:08 ` bug#64531: [PATCH v3] Add new commands for copying VC filenames Ivan Sokolov
2023-09-05 11:01   ` Eli Zaretskii
2023-10-19 23:39     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkf2xmjy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64531@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=ivan-p-sokolov@ya.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).