From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64531: [PATCH v2] Add new command vc-dir-copy-filename-as-kill Date: Sun, 20 Aug 2023 09:20:01 +0300 Message-ID: <83bkf2xmjy.fsf@gnu.org> References: <87bkgmq1ra.fsf@ya.ru> <83jzvadabq.fsf@gnu.org> <87bkfhy7fr.fsf_-_@ya.ru> <83a5un1mn3.fsf@gnu.org> <87sf8eeie7.fsf@ya.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40850"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64531@debbugs.gnu.org, dgutov@yandex.ru To: Ivan Sokolov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 08:20:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXbnO-000AMR-LB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 08:20:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXbn9-0001vB-KP; Sun, 20 Aug 2023 02:20:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXbn7-0001tr-DZ for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 02:20:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXbn6-0003i4-VK for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 02:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXbn8-0000U3-Cd for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 02:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64531 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64531-submit@debbugs.gnu.org id=B64531.16925123971844 (code B ref 64531); Sun, 20 Aug 2023 06:20:02 +0000 Original-Received: (at 64531) by debbugs.gnu.org; 20 Aug 2023 06:19:57 +0000 Original-Received: from localhost ([127.0.0.1]:52771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXbn2-0000Tg-Kz for submit@debbugs.gnu.org; Sun, 20 Aug 2023 02:19:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXbn0-0000TS-6q for 64531@debbugs.gnu.org; Sun, 20 Aug 2023 02:19:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXbms-0003hR-IA; Sun, 20 Aug 2023 02:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7vbldJsbH8yK0WH8F4G2LKnVZlIRXQqx4RI0zaveRwQ=; b=SoLGhDgoDz8d 6DeNx1zqiVqfx7QmmGKiIrJ6W/Rajj2wFufiZYS9cNWcG02IQyBVa3t0l4D66Ef6xiTLVaPBxplgL 2GJb51quQPv8Wqsib7tKUIYorh8pxQmG3LEaWs1CYod/0C+mlRpSmccQ+eXC1aSo+iaYjrQi9egXg fizSr49H21fkA5dfqR+mZUJuqHDf0hWYH7+YAHKmnuAA+9X3bmAx4z8ik+V9PcyEckZvudEcVvT4A 1s0unTLu2PE4DBJnd/TOkvWiWhcRoIstUkJBqrMKwRyRl3C1mjed1NpqAv8MT58Rq9Nxub6Qvz6vT ZfBKT5bhO0TheF39r1BRJA==; In-Reply-To: <87sf8eeie7.fsf@ya.ru> (message from Ivan Sokolov on Sun, 20 Aug 2023 02:12:32 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267947 Archived-At: > From: Ivan Sokolov > Cc: Dmitry Gutov , 64531@debbugs.gnu.org > Date: Sun, 20 Aug 2023 02:12:32 +0300 > > Eli Zaretskii writes: > > >> From: Ivan Sokolov > >> Cc: 64531@debbugs.gnu.org > >> Date: Tue, 08 Aug 2023 16:44:56 +0300 > >> > >> Eli Zaretskii writes: > >> > >> > However, new commands should be called out in NEWS, and commands that > >> > are important enough should also be mentioned in the user manual. > >> > >> Added entry in NEWS, but not in the user manual, there is no such for > >> vc-dir afaik. > >> > >> >> +(defun vc-dir-copy-filename-as-kill (&optional absolutep) > >> >> + "Copy names of marked files (or file under cursor) into the kill ring. > >> > > >> > This sentence is too general: it doesn't mention VC Dir, although > >> > AFAIU it is specific to vc-dir. > >> > >> Fixed. > > > > Dmitry, is this good to go in? > > > > I still think it should be mention in the Emacs user manual, where we > > document vc-dir. > > Hi, Eli! > > I am working on the 3rd version of the patch with all the necessary > documentation and changes to the command which I will explain in the > cover letter. Not sure when I'll finish it though. Good to hear, and TIA. There's no rush, so take your time. (I will ping again if it takes too long IMO ;-)