From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org
Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work
Date: Tue, 24 Oct 2023 18:41:49 +0300 [thread overview]
Message-ID: <83bkcokoxu.fsf@gnu.org> (raw)
In-Reply-To: <jwv1qdkyt4l.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Tue, 24 Oct 2023 10:50:03 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org
> Date: Tue, 24 Oct 2023 10:50:03 -0400
>
> > change if the change is small enough. So I'm not sure I understand
> > what is new in your idea, if you want to keep the double-click-fuzz
> > test.
>
> What's new is the `mouse_has_moved` boolean which remembers if the mouse
> has been moved some time between the down and the up, contrary to the
> current code which only looks at the relative position of the down and
> the up.
With the current code, if I move the mouse between the events, but the
coordinates differ by less than double-click-fuzz, we will not
generate a drag event. If the mouse-moved flag overrides that, we
will generate a drag event where previously we didn't, isn't that so?
> The patch looks big mostly because it reverts your patch.
I know, and that doesn't bother me per se.
next prev parent reply other threads:[~2023-10-24 15:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 20:27 bug#66655: 29.1; Clicking buttons sometimes doesn't work tomasralph2000
2023-10-20 20:38 ` Stefan Kangas
2023-10-21 10:57 ` Eli Zaretskii
2023-10-21 11:23 ` Stefan Kangas
2023-10-21 11:34 ` Eli Zaretskii
2023-10-21 12:05 ` Stefan Kangas
2023-10-23 16:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-23 18:30 ` Eli Zaretskii
2023-10-23 22:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-24 12:14 ` Eli Zaretskii
2023-10-24 13:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-24 13:53 ` Eli Zaretskii
2023-10-24 13:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-24 14:18 ` Eli Zaretskii
2023-10-24 14:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-24 14:36 ` Eli Zaretskii
2023-10-24 14:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-24 15:41 ` Eli Zaretskii [this message]
2023-10-24 22:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-25 11:59 ` Eli Zaretskii
2023-10-25 15:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-25 16:08 ` Eli Zaretskii
2023-10-25 16:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-25 16:45 ` Eli Zaretskii
2023-10-25 17:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-25 18:29 ` Eli Zaretskii
2023-10-25 21:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-26 5:07 ` Eli Zaretskii
2023-10-26 14:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-24 13:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-23 23:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkcokoxu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66655@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tomasralph2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).