From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work Date: Tue, 24 Oct 2023 18:41:49 +0300 Message-ID: <83bkcokoxu.fsf@gnu.org> References: <1d9187b71e7288eaf08ac9a2f0559bdf@gmail.com> <8334y4s0oe.fsf@gnu.org> <83v8axmbsh.fsf@gnu.org> <83y1fskyjj.fsf@gnu.org> <83il6wktxt.fsf@gnu.org> <83h6mgkst3.fsf@gnu.org> <83edhkkrzd.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25212"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 24 17:43:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvJZL-0006Bt-IW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Oct 2023 17:43:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvJYN-0004YN-Cl; Tue, 24 Oct 2023 11:42:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvJYA-0004SJ-L4 for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 11:42:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvJY9-0007ur-Ai for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 11:42:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvJYc-00044y-Tr for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 11:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2023 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66655 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 66655-submit@debbugs.gnu.org id=B66655.169816214315603 (code B ref 66655); Tue, 24 Oct 2023 15:43:02 +0000 Original-Received: (at 66655) by debbugs.gnu.org; 24 Oct 2023 15:42:23 +0000 Original-Received: from localhost ([127.0.0.1]:56350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvJXz-00043b-GK for submit@debbugs.gnu.org; Tue, 24 Oct 2023 11:42:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvJXx-00043O-FN for 66655@debbugs.gnu.org; Tue, 24 Oct 2023 11:42:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvJXN-0007kZ-TB; Tue, 24 Oct 2023 11:41:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CHJjVK6KPkCwIbGFQs83mRZTg6Hty8cO21/PVy0oHLo=; b=qCHKG1RmuWXb VYLhG0bV1veHS6UodW70KqIbx+hYyulntTxCkAQmUadIbPUN2ql836Op7VDoN0yOWgtAZBwBgPavo uJ1jS0X/2sEQ4KP7B9tRjd1yIvaD0nI2n+fJkgaR9L/yL/9XLhPyWgFdGZEQ4lclIWpCxk2jGEkE/ +CvcmYtNESlXQ3cbRHtYz1UL8Bu1IavA/AvEPmmCX4GarbQ0yqP4rmHHK5WJ2M+7bDnjhw/tHuLGq PKJNtTz9cuW4Pyhrz7f1gXSIbVXiVzVOCqn+SpK6FriQV/nU4PUpA2SYO5Y23ic5xiHzCL+S+Fwbi Wpwq4YEzFi64t3fQ5eQ7xA==; In-Reply-To: (message from Stefan Monnier on Tue, 24 Oct 2023 10:50:03 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273113 Archived-At: > From: Stefan Monnier > Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org > Date: Tue, 24 Oct 2023 10:50:03 -0400 > > > change if the change is small enough. So I'm not sure I understand > > what is new in your idea, if you want to keep the double-click-fuzz > > test. > > What's new is the `mouse_has_moved` boolean which remembers if the mouse > has been moved some time between the down and the up, contrary to the > current code which only looks at the relative position of the down and > the up. With the current code, if I move the mouse between the events, but the coordinates differ by less than double-click-fuzz, we will not generate a drag event. If the mouse-moved flag overrides that, we will generate a drag event where previously we didn't, isn't that so? > The patch looks big mostly because it reverts your patch. I know, and that doesn't bother me per se.