bug#11230: 24.1.50; VC doesn't handle internal errors?

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Deniz Dogan]

I just compiled the latest Emacs on 64-bit Windows 7 myself and when I
was going to look at the Bazaar log, I found the following error.

I do:

1) runemacs.exe -Q
2) C-x v d D:/repos/emacs/trunk ;; my branch
3) The following is the output in the vc-dir buffer:


VC backend : Bzr
Working dir: d:/repos/emacs/trunk/
Parent branch      : bzr+ssh://damd@bzr.savannah.gnu.org/emacs/trunk/
Shelves            : No shelved changes

                         ./
    nil                  
***
    nil                  
Tra
    nil                  
bzr
    nil                  Bazaar has encountered an internal error.  This probably indicates a
    nil                  Error: run() got an unexpected keyword argument 'no_classify'
    nil                  bug in Bazaar.  You can help us fix it by filing a bug report at
    nil                  ding: 'cp1252', fsenc: 'mbcs', lang: 'SVE'
    nil                  eback (most recent call last):
    nil                  explorer[1.2.1], fastimport[0.12.0dev], launchpad[2.4.2], loom[2.2.1dev],
    nil                  including this traceback and a description of the problem.
    nil                  ins: bzrtools[2.4.1], changelog_merge[2.4.2], colo[0.3.1dev],
    nil                  netrc_credential_store[2.4.2], news_merge[2.4.2], pipeline[1.1.0],
    nil                  qbzr[0.21.1], rewrite[0.6.3dev], svn[1.1.0], upload[1.0.1dev],
    nil                  xmloutput[0.8.7]
                             https:/bugs.launchpad.net/bzr/
    nil                      https:/bugs.launchpad.net/bzr/+filebug
                         classify', '-v', '-S', './
    nil                  classify', '-v', '-S', './']
                         le "C:/Program Files (x86)/Bazaar/plugins/loom/
    nil                  le "C:/Program Files (x86)/Bazaar/plugins/loom/commands.py", line 203, in run_argv_aliases
                         le "bzrlib/
    nil                  le "bzrlib/cleanup.pyo", line 135, in run_simple
    nil                  le "bzrlib/cleanup.pyo", line 165, in _do_with_cleanups
    nil                  le "bzrlib/commands.pyo", line 1150, in run_bzr
    nil                  le "bzrlib/commands.pyo", line 699, in run_argv_aliases
    nil                  le "bzrlib/commands.pyo", line 721, in run
    nil                  le "bzrlib/commands.pyo", line 946, in exception_to_return_code
                         ments: ['c:/Program Files (x86)/Bazaar/
    nil                  ments: ['c:/Program Files (x86)/Bazaar/bzr.exe', 'status', '--no-



More information:

D:\repos\emacs\trunk>bzr info
Standalone tree (format: 2a)
Location:
  branch root: .

Related branches:
  parent branch: bzr+ssh://damd@bzr.savannah.gnu.org/emacs/trunk/

D:\repos\emacs\trunk>bzr status
<empty line>

D:\repos\emacs\trunk>bzr log -l 1
------------------------------------------------------------
revno: 107874
committer: Stefan Monnier <monnier@iro.umontreal.ca>
branch nick: trunk
timestamp: Wed 2012-04-11 14:13:20 -0400
message:
  * lisp/subr.el (read-passwd): Use read-string.

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Glenn Morris]

Deniz Dogan wrote:

>     nil                  Bazaar has encountered an internal error.

Your bzr is broken. Obviously vc-dir cannot work with this.
It is a bug in bzr. Emacs shows you the error from bzr (maybe not in the
nicest way), so that you can fix it. What else do you think Emacs should
do about this?

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Deniz Dogan]

On 2012-04-12 19:44, Glenn Morris wrote:
> Deniz Dogan wrote:
>
>>      nil                  Bazaar has encountered an internal error.
>
> Your bzr is broken. Obviously vc-dir cannot work with this.
> It is a bug in bzr. Emacs shows you the error from bzr (maybe not in the
> nicest way), so that you can fix it. What else do you think Emacs should
> do about this?

Bazaar works just fine from the command-line for all repositories for 
me.  When I do vc-dir on a Git repository, it reports no errors.  When I 
do vc-dir on another Bazaar repository (not Emacs related), I get the 
same error as in this bug report.

This leads me to believe there's a bug in vc-bzr.el or at least room for 
improvement.  I feel that Emacs should at least be able to display the 
entire error message in a readable fashion and not just assume the 
operation worked.

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Glenn Morris]

Deniz Dogan wrote:

> Bazaar works just fine from the command-line for all repositories for
> me.  

Try from the command-line

bzr status --no-classify

> I feel that Emacs should at least be able to display the entire error
> message in a readable fashion and not just assume the operation worked.

It what way is it assuming the operation worked?

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Deniz Dogan]

On 2012-04-12 19:56, Glenn Morris wrote:
> Deniz Dogan wrote:
>
>> Bazaar works just fine from the command-line for all repositories for
>> me.
>
> Try from the command-line
>
> bzr status --no-classify
>

You're right, when I pass --no-classify it breaks in the command-line as 
well.

>> I feel that Emacs should at least be able to display the entire error
>> message in a readable fashion and not just assume the operation worked.
>
> It what way is it assuming the operation worked?

The return code from bzr is non-zero (4 in fact).  This should indicate 
an error of some sort and Emacs should be able to handle it.

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Glenn Morris]

Deniz Dogan wrote:

> You're right, when I pass --no-classify it breaks in the command-line
> as well.

And if `bzr help status' lists the --no-classify option (which it
presumably does, else Emacs would not try to use it), then this is a bug
in bzr. I hope you will report it to bzr.

You can set vc-bzr-status-switches to nil to work around it.

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Deniz Dogan]

On 2012-04-12 20:08, Glenn Morris wrote:
> Deniz Dogan wrote:
>
>> You're right, when I pass --no-classify it breaks in the command-line
>> as well.
>
> And if `bzr help status' lists the --no-classify option (which it
> presumably does, else Emacs would not try to use it), then this is a bug
> in bzr. I hope you will report it to bzr.
>
> You can set vc-bzr-status-switches to nil to work around it.

I've reported it to Bazaar.  Thanks.

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Glenn Morris]

Maybe Emacs should test that the option works, not just that it is
present. I don't know; it's a slightly more expensive test. (Make a temp
repo, check status, delete it.)

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Deniz Dogan]

On 2012-04-12 21:00, Glenn Morris wrote:
>
> Maybe Emacs should test that the option works, not just that it is
> present. I don't know; it's a slightly more expensive test. (Make a temp
> repo, check status, delete it.)

I am not that familiar with VC or Bazaar, but is it really necessary to 
do all of that?  Couldn't we simply check the return code from every 
Bazaar command and act depending on the result of that?  Maybe it's 
simpler said than done...

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Eli Zaretskii]

> From: Deniz Dogan <deniz@dogan.se>
> Date: Thu, 12 Apr 2012 19:40:28 +0200
> 
> I just compiled the latest Emacs on 64-bit Windows 7 myself and when I
> was going to look at the Bazaar log, I found the following error.
> 
> I do:
> 
> 1) runemacs.exe -Q
> 2) C-x v d D:/repos/emacs/trunk ;; my branch
> 3) The following is the output in the vc-dir buffer:
> 
> 
> VC backend : Bzr
> Working dir: d:/repos/emacs/trunk/
> Parent branch      : bzr+ssh://damd@bzr.savannah.gnu.org/emacs/trunk/
> Shelves            : No shelved changes
> 
>                          ./
>     nil                  
> ***
>     nil                  
> Tra
>     nil                  
> bzr
>     nil                  Bazaar has encountered an internal error.  This probably indicates a
>     nil                  Error: run() got an unexpected keyword argument 'no_classify'
>     nil                  bug in Bazaar.  You can help us fix it by filing a bug report at
>     nil                  ding: 'cp1252', fsenc: 'mbcs', lang: 'SVE'
>     nil                  eback (most recent call last):
>     nil                  explorer[1.2.1], fastimport[0.12.0dev], launchpad[2.4.2], loom[2.2.1dev],
>     nil                  including this traceback and a description of the problem.
>     nil                  ins: bzrtools[2.4.1], changelog_merge[2.4.2], colo[0.3.1dev],
>     nil                  netrc_credential_store[2.4.2], news_merge[2.4.2], pipeline[1.1.0],
>     nil                  qbzr[0.21.1], rewrite[0.6.3dev], svn[1.1.0], upload[1.0.1dev],

Upgrade your bzr.

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Glenn Morris]

Deniz Dogan wrote:

>> Maybe Emacs should test that the option works, not just that it is
>> present. I don't know; it's a slightly more expensive test. (Make a temp
>> repo, check status, delete it.)
>
> I am not that familiar with VC or Bazaar, but is it really necessary
> to do all of that?  Couldn't we simply check the return code from
> every Bazaar command and act depending on the result of that?

We're talking at cross purposes. I was talking about setting the default
value of vc-bzr-status-switches more rigorously.

The vc-bzr-status command cannot return an error, because it is invoked
all the time, on simply visiting a file in a bzr-controlled directory.
So an error here might make it impossible to edit a file; or even to
build Emacs [1]. The best Emacs can do is convert the error to a message
and report it, which is what it does already. I vaguely recall that it's
a design decision of vc-dir that it puts any error in the actual vc-dir
buffer. A multi-line backtrace from a crashing external program is not a
typical expected case.

[1] http://lists.gnu.org/archive/html/help-gnu-emacs/2012-04/msg00145.html

bug#11230: 24.1.50; VC doesn't handle internal errors?

[Christoph Scholtes]

Deniz Dogan <deniz@dogan.se> writes:

> I just compiled the latest Emacs on 64-bit Windows 7 myself and when I
> was going to look at the Bazaar log, I found the following error.

[snip]

I got the same error with bzr 2.4.2. After upgrading to bzr 2.5.0 the
error disappeared.

However, the bzr error (with the backtrace) did not always occur. It
actually occurred repeatable when vc-dir was invoked at the root of the
Emacs trunk repo. 

If vc-dir is invoked at a lower level, say the lisp directory, Emacs
would report the following error:

error in process sentinel: vc-dir-node-directory: Wrong type argument: arrayp, nil
error in process sentinel: Wrong type argument: arrayp, nil

I reported a similar issue in bug #9726, which Glenn fixed (see bug
#9726 thread), but is there still an issue here?

Note, that this behavior also disappears with the upgrade to bzr 2.5.0.