unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: 57837@debbugs.gnu.org, sds@gnu.org
Subject: bug#57837: 29.0.50; fit-window-to-buffer should reposition the buffer
Date: Sat, 17 Sep 2022 09:48:43 +0300	[thread overview]
Message-ID: <83a66y3390.fsf@gnu.org> (raw)
In-Reply-To: <84acc36e7e748d1b29fd@heytings.org> (message from Gregory Heytings on Fri, 16 Sep 2022 21:34:01 +0000)

> Cc: 57837@debbugs.gnu.org
> Date: Fri, 16 Sep 2022 21:34:01 +0000
> From: Gregory Heytings <gregory@heytings.org>
> 
> > is it possible for Emacs return nil from (pos-visible-in-window-p 
> > (point))
> 
> It is not impossible, but if it happens, it's a bug.

Actually, it _is_ possible and is not a bug, but only as long as
redisplay didn't happen.  IOW, you can, for example, write a command
that moves point in a way that would make point be outside of the
window, and then pos-visible-in-window-p will return nil for it.  But
as soon as the command finishes, redisplay will scroll the window to
bring point into view.

This is exactly what you see in this case.

> I get that that's your preference, but I hope you understand that this is 
> a corner case, and that what the code does is not a bug.

Right.





  reply	other threads:[~2022-09-17  6:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 17:31 bug#57837: 29.0.50; fit-window-to-buffer should reposition the buffer Sam Steingold
2022-09-15 18:03 ` Eli Zaretskii
2022-09-15 18:30   ` Sam Steingold
2022-09-15 18:55     ` Sam Steingold
2022-09-15 19:07       ` Eli Zaretskii
2022-09-15 22:52         ` Sam Steingold
2022-09-16  5:53           ` Eli Zaretskii
2022-09-15 19:00     ` Eli Zaretskii
2022-09-15 19:34 ` Gregory Heytings
2022-09-15 22:45   ` Sam Steingold
2022-09-15 22:59     ` Gregory Heytings
2022-09-16 18:52       ` Sam Steingold
2022-09-16 19:34         ` Gregory Heytings
2022-09-16 21:25           ` Sam Steingold
2022-09-16 21:34             ` Gregory Heytings
2022-09-17  6:48               ` Eli Zaretskii [this message]
2022-09-17  7:10                 ` Gregory Heytings
2022-09-17  7:25                   ` Eli Zaretskii
2022-09-18  8:34               ` Gregory Heytings
2022-09-16  5:45     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a66y3390.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57837@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).