From: Eli Zaretskii <eliz@gnu.org>
To: sds@gnu.org
Cc: 57837@debbugs.gnu.org
Subject: bug#57837: 29.0.50; fit-window-to-buffer should reposition the buffer
Date: Thu, 15 Sep 2022 22:00:36 +0300 [thread overview]
Message-ID: <838rmk5up7.fsf@gnu.org> (raw)
In-Reply-To: <lzillopk1f.fsf@3c22fb11fdab.ant.amazon.com> (message from Sam Steingold on Thu, 15 Sep 2022 14:30:36 -0400)
> From: Sam Steingold <sds@gnu.org>
> Cc: 57837@debbugs.gnu.org
> Date: Thu, 15 Sep 2022 14:30:36 -0400
>
> >> Basically, after `fit-window-to-buffer' is called, the following should
> >> evaluate to t:
> >>
> >> --8<---------------cut here---------------start------------->8---
> >> (and (pos-visible-in-window-p (point-min))
> >> (pos-visible-in-window-p (point-max)))
> >> --8<---------------cut here---------------end--------------->8---
> >
> > No, because point-max is after the last newline, and thus effectively
> > one line beyond the window's text.
>
> As I said, if `fit-window-to-buffer' has a "contract", it's the invariant
> above. Violating it, albeit in a corner case, is, IMO, a bug.
I think you misunderstand the contract: the function fits the window
to the buffer text, which doesn't include the (imaginary) place beyond
the last character.
When you are are EOB, doesn't "C-x =" say something like
point=N out of N-1 (EOB)
? Do you see what I mean by "beyond the last character"?
> I am not sure how this should be fixed
It shouldn't be fixed, because it ain't broken.
next prev parent reply other threads:[~2022-09-15 19:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 17:31 bug#57837: 29.0.50; fit-window-to-buffer should reposition the buffer Sam Steingold
2022-09-15 18:03 ` Eli Zaretskii
2022-09-15 18:30 ` Sam Steingold
2022-09-15 18:55 ` Sam Steingold
2022-09-15 19:07 ` Eli Zaretskii
2022-09-15 22:52 ` Sam Steingold
2022-09-16 5:53 ` Eli Zaretskii
2022-09-15 19:00 ` Eli Zaretskii [this message]
2022-09-15 19:34 ` Gregory Heytings
2022-09-15 22:45 ` Sam Steingold
2022-09-15 22:59 ` Gregory Heytings
2022-09-16 18:52 ` Sam Steingold
2022-09-16 19:34 ` Gregory Heytings
2022-09-16 21:25 ` Sam Steingold
2022-09-16 21:34 ` Gregory Heytings
2022-09-17 6:48 ` Eli Zaretskii
2022-09-17 7:10 ` Gregory Heytings
2022-09-17 7:25 ` Eli Zaretskii
2022-09-18 8:34 ` Gregory Heytings
2022-09-16 5:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rmk5up7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=57837@debbugs.gnu.org \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).