* bug#66179: 30.0.50; Missing choice in tmm-mid-prompt :type
@ 2023-09-24 12:29 Mauro Aranda
2023-09-24 12:31 ` Mauro Aranda
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-09-24 12:29 UTC (permalink / raw)
To: 66179
The docstring of tmm-mid-prompt says its value can be nil, but its :type
is just string.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66179: 30.0.50; Missing choice in tmm-mid-prompt :type
2023-09-24 12:29 bug#66179: 30.0.50; Missing choice in tmm-mid-prompt :type Mauro Aranda
@ 2023-09-24 12:31 ` Mauro Aranda
2023-09-25 7:35 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-09-24 12:31 UTC (permalink / raw)
To: 66179
[-- Attachment #1: Type: text/plain, Size: 39 bytes --]
tags 66179 patch
quit
Patch attached.
[-- Attachment #2: 0001-Fix-tmm-mid-prompt-type-Bug-66179.patch --]
[-- Type: text/x-patch, Size: 849 bytes --]
From 93e8966e1d6b1e9814cfa217918936119b3f0453 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Sun, 24 Sep 2023 09:31:01 -0300
Subject: [PATCH] Fix tmm-mid-prompt :type (Bug#66179)
* lisp/tmm.el (tmm-mid-prompt): Allow nil.
---
lisp/tmm.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/tmm.el b/lisp/tmm.el
index a4058594622..b587b416a35 100644
--- a/lisp/tmm.el
+++ b/lisp/tmm.el
@@ -79,7 +79,8 @@ tmm-mid-prompt
"String to insert between shortcut and menu item.
If nil, there will be no shortcuts. It should not consist only of spaces,
or else the correct item might not be found in the `*Completions*' buffer."
- :type 'string)
+ :type '(choice (const :tag "No shortcuts" nil)
+ string))
(defvar tmm-mb-map nil
"A place to store minibuffer map.")
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#66179: 30.0.50; Missing choice in tmm-mid-prompt :type
2023-09-24 12:31 ` Mauro Aranda
@ 2023-09-25 7:35 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-09-25 7:35 UTC (permalink / raw)
To: Mauro Aranda; +Cc: 66179-done
> Date: Sun, 24 Sep 2023 09:31:53 -0300
> From: Mauro Aranda <maurooaranda@gmail.com>
>
> Patch attached.
Thanks, installed on the emacs-29 branch, and closing the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-25 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-24 12:29 bug#66179: 30.0.50; Missing choice in tmm-mid-prompt :type Mauro Aranda
2023-09-24 12:31 ` Mauro Aranda
2023-09-25 7:35 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).