unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: eenliu@gmail.com, 14326@debbugs.gnu.org
Subject: bug#14326: 24.3; Conflict of w32-send-sys-command and set-default-font
Date: Thu, 02 May 2013 22:38:43 +0300	[thread overview]
Message-ID: <838v3xnpdo.fsf@gnu.org> (raw)
In-Reply-To: <5182B999.4050304@gmx.at>

> Date: Thu, 02 May 2013 21:08:09 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: eenliu@gmail.com, 14326@debbugs.gnu.org
> 
>  > The code thus commented is ifdef'ed away...
> 
> That's what I'm wondering about.

You cannot just call change_frame_size on Windows anyway.  It doesn't
do what you'd expect.

>  > That's not the issue here.  The issue here is that, when
>  > w32-send-sys-command is used, Emacs doesn't have any way of knowing
>  > that this call is going to change the frame's size.  The argument to
>  > w32-send-sys-command is just some mumbo-jumbo as far as Emacs is
>  > concerned.  Only when the WM_SIZE message comes in as result of that,
>  > do we know that the frame size is about to change.
> 
> So w32-send-sys-command is handled differently from setting the
> fullscreen frame parameter to maximized?

Not really: the latter is implemented by calling the former (or
actually doing the same independently).

> Does this mean the OP could have used `set-frame-parameter' and it
> would have worked in his sense?

No, see above.

>  > By contrast, set-default-font works in the opposite direction: Emacs
>  > _does_ understand what that means, it does know how to load a font and
>  > get its metrics, and it does know how to resize the frame as result.
> 
> But when x_set_window_size tells Windows that it wants to resize the
> frame, it stumbles into some away-defined code.

Not sure what x_set_window_size has to do with all this.

>  > So even if the actual resize involves some messages that need to come
>  > to our window procedure, that doesn't matter, because we are already
>  > ready for the resize.  Not so when w32-send-sys-command is used.
>  >
>  > Or at least this is my understanding, admittedly very limited in this
>  > area.
>  >
>  > Btw, try "M-: (set-default-font "David-8") RET" in "emacs -Q", and you
>  > will see that the tool bar (not the menu bar) will wrap, but I see no
>  > adverse effects of that.  So I really don't see why we should be
>  > afraid of such wrapping.
> 
> We do our own toolbar wrapping.  But the menubar is wrapped by Windows.

And that is a problem because...?





  reply	other threads:[~2013-05-02 19:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01  1:34 bug#14326: 24.3; Conflict of w32-send-sys-command and set-default-font Eric Liu
2013-05-01  9:15 ` martin rudalics
2013-05-01 15:02   ` Eli Zaretskii
2013-05-01 17:33     ` Eric Liu
2013-05-01 17:37       ` Eli Zaretskii
2013-05-02  9:23     ` martin rudalics
2013-05-02 17:08       ` Eli Zaretskii
2013-05-02 18:32         ` martin rudalics
2013-05-02 18:55           ` Eli Zaretskii
2013-05-02 19:08             ` martin rudalics
2013-05-02 19:38               ` Eli Zaretskii [this message]
2013-05-03  6:48                 ` martin rudalics
2013-05-03  7:12                   ` Eli Zaretskii
2013-05-03  7:28                     ` martin rudalics
2013-05-03 14:59                   ` Drew Adams
2013-05-03 15:48                     ` Eli Zaretskii
2013-05-03 15:54                       ` Eli Zaretskii
2013-05-03 16:26                       ` Drew Adams
2013-05-03 18:04                         ` Eli Zaretskii
2013-05-03 18:19                           ` Drew Adams
2013-05-03 19:25                             ` Eli Zaretskii
2013-05-03 18:59                       ` martin rudalics
2013-05-03 20:06                         ` Drew Adams
2013-05-03 20:18                           ` Eli Zaretskii
2013-05-03 20:31                             ` Drew Adams
2013-05-04  6:37                               ` Eli Zaretskii
2013-05-04  7:50                                 ` martin rudalics
2013-05-04 14:17                                 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838v3xnpdo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=14326@debbugs.gnu.org \
    --cc=eenliu@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).