unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 20728@debbugs.gnu.org
Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument
Date: Thu, 04 Jun 2015 18:01:50 +0300	[thread overview]
Message-ID: <838ubzqzz5.fsf@gnu.org> (raw)
In-Reply-To: <5570132A.9060109@yandex.ru>

> Cc: 20728@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 4 Jun 2015 11:58:18 +0300
> 
> On 06/04/2015 05:43 AM, Eli Zaretskii wrote:
> 
> > I don't understand what you perceive as a problem with the current
> > code, and why.
> 
> The fact that we have to do a replace-regexp-in-string in 
> xref-collect-matches, as well as in semantic-symref-grep-use-template.
> 
> Whereas we should be able to simply bind grep-highlight-matches to nil 
> before calling grep-expand-template.

Why not allow users of grep.el bind grep-highlight-matches to
whatever, including nil, and make grep.el obey that?  Using a template
for such a simple job sounds like over-engineering to me.  I can
understand why the template is used in find-grep and related commands:
the 'find' or 'xargs' command line is somewhat tricky.  But there's no
such problem with 'grep', so I'm unsure why we want to use a template
there, let alone have a placeholder for that switch in the template.





  reply	other threads:[~2015-06-04 15:01 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 23:42 bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Dmitry Gutov
2015-06-04  2:43 ` Eli Zaretskii
2015-06-04  8:58   ` Dmitry Gutov
2015-06-04 15:01     ` Eli Zaretskii [this message]
2015-06-04 15:18       ` Dmitry Gutov
2015-06-04 15:34         ` Eli Zaretskii
2015-06-04 15:36           ` Dmitry Gutov
2015-06-04 15:39             ` Eli Zaretskii
2015-06-04 16:55               ` Dmitry Gutov
2015-06-04 17:16                 ` Eli Zaretskii
2015-06-04 17:46                   ` Dmitry Gutov
2015-06-04 19:23                     ` Eli Zaretskii
2015-06-04 20:20                       ` Dmitry Gutov
2015-06-05  6:58                         ` Eli Zaretskii
2015-06-05  8:29                           ` Dmitry Gutov
2015-06-05  8:59                             ` Eli Zaretskii
2015-06-05  9:07                               ` Dmitry Gutov
2015-06-05  9:23                                 ` Eli Zaretskii
2015-06-05  9:47                                   ` Dmitry Gutov
2015-06-05 22:17                                     ` Juri Linkov
2015-06-06 10:19                                       ` Dmitry Gutov
2015-06-06 22:04                                         ` Juri Linkov
2015-06-07 22:22                                           ` Dmitry Gutov
2015-06-09 23:32                                             ` Juri Linkov
2015-06-10 17:55                                               ` Dmitry Gutov
2015-06-10 23:49                                                 ` Juri Linkov
2015-06-11  7:23                                                   ` Dmitry Gutov
2015-06-11 23:20                                                     ` Juri Linkov
2015-06-22  0:49                                                       ` Dmitry Gutov
2015-06-22 22:33                                                         ` Juri Linkov
2015-06-23  0:33                                                           ` Dmitry Gutov
2015-06-27 21:11                                                       ` Dmitry Gutov
2015-06-27 22:49                                                         ` Juri Linkov
2015-06-28  1:22                                                           ` Dmitry Gutov
2015-06-28  1:39                                                             ` Dmitry Gutov
2015-06-28  2:42                                                         ` Eli Zaretskii
2015-06-28  8:05                                                           ` Dmitry Gutov
2015-06-28 14:35                                                             ` Eli Zaretskii
2015-06-28 19:02                                                               ` Dmitry Gutov
2015-06-28 20:28                                                                 ` Eli Zaretskii
2015-06-28 20:31                                                                   ` Dmitry Gutov
2015-06-29  2:36                                                                     ` Eli Zaretskii
2015-06-29 10:08                                                                       ` Dmitry Gutov
2015-06-29 14:49                                                                         ` Eli Zaretskii
2015-06-29 15:01                                                                           ` Dmitry Gutov
2015-06-29 15:26                                                                             ` Eli Zaretskii
2015-06-29 16:11                                                                               ` Dmitry Gutov
2015-06-29 16:24                                                                                 ` Eli Zaretskii
2015-06-29 16:26                                                                                   ` Dmitry Gutov
2015-07-11 13:58                                                                                   ` Eli Zaretskii
2015-07-11 15:57                                                                                     ` Dmitry Gutov
2015-06-29 10:05                                                                   ` Dmitry Gutov
2015-06-29 14:44                                                                     ` Eli Zaretskii
2015-06-29 14:50                                                                       ` Dmitry Gutov
2015-06-29 15:15                                                                         ` Eli Zaretskii
2015-06-04 22:50 ` Juri Linkov
2015-06-05  9:49   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838ubzqzz5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=20728@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).