From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Date: Thu, 04 Jun 2015 18:01:50 +0300 Message-ID: <838ubzqzz5.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1433430218 12344 80.91.229.3 (4 Jun 2015 15:03:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Jun 2015 15:03:38 +0000 (UTC) Cc: 20728@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 04 17:03:22 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z0Wfo-00071h-1J for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Jun 2015 17:03:12 +0200 Original-Received: from localhost ([::1]:42801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Wfn-00080u-Ha for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Jun 2015 11:03:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Wfj-00080R-FP for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2015 11:03:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0Wff-0008ID-E3 for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2015 11:03:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Wff-0008I4-BN for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2015 11:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z0Wfe-0000YR-Rn for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2015 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14334301272061 (code B ref 20728); Thu, 04 Jun 2015 15:03:02 +0000 Original-Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 15:02:07 +0000 Original-Received: from localhost ([127.0.0.1]:40663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Wek-0000X9-7s for submit@debbugs.gnu.org; Thu, 04 Jun 2015 11:02:06 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:60564) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Weg-0000Wc-Kb for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 11:02:03 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NPF00L00DOV6E00@a-mtaout20.012.net.il> for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 18:01:55 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPF00KSHDR7X6A0@a-mtaout20.012.net.il>; Thu, 04 Jun 2015 18:01:55 +0300 (IDT) In-reply-to: <5570132A.9060109@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103561 Archived-At: > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Jun 2015 11:58:18 +0300 > > On 06/04/2015 05:43 AM, Eli Zaretskii wrote: > > > I don't understand what you perceive as a problem with the current > > code, and why. > > The fact that we have to do a replace-regexp-in-string in > xref-collect-matches, as well as in semantic-symref-grep-use-template. > > Whereas we should be able to simply bind grep-highlight-matches to nil > before calling grep-expand-template. Why not allow users of grep.el bind grep-highlight-matches to whatever, including nil, and make grep.el obey that? Using a template for such a simple job sounds like over-engineering to me. I can understand why the template is used in find-grep and related commands: the 'find' or 'xargs' command line is somewhat tricky. But there's no such problem with 'grep', so I'm unsure why we want to use a template there, let alone have a placeholder for that switch in the template.