From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: van@scratch.space, 33237@debbugs.gnu.org
Subject: bug#33237: 26.1, 7.3 emacs-mac: <fnum> list order in C-h b
Date: Wed, 10 Jul 2019 18:02:36 +0300 [thread overview]
Message-ID: <838st63pbn.fsf@gnu.org> (raw)
In-Reply-To: <87lfx63tai.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Wed, 10 Jul 2019 15:36:53 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 10 Jul 2019 15:36:53 +0200
> Cc: 33237@debbugs.gnu.org
>
> <f1> help-command
> <f2> 2C-command
> <f3> kmacro-start-macro-or-insert-counter
> <f4> kmacro-end-or-call-macro
> <f10> menu-bar-open
> <f11> toggle-frame-fullscreen
> <f16> clipboard-kill-ring-save
> <f18> clipboard-yank
> <f20> clipboard-kill-region
>
> Looks nicer to me. Does anybody object to this change?
>
> diff --git a/src/keymap.c b/src/keymap.c
> index 2ac3d33460..8c2c209e64 100644
> --- a/src/keymap.c
> +++ b/src/keymap.c
> @@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb)
> if (FIXNUMP (a->event) && !FIXNUMP (b->event))
> return -1;
> if (SYMBOLP (a->event) && SYMBOLP (b->event))
> - return (!NILP (Fstring_lessp (a->event, b->event)) ? -1
> - : !NILP (Fstring_lessp (b->event, a->event)) ? 1
> + return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1
> + : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1
> : 0);
> return 0;
> }
It sounds very strange to use string-version-lessp here, so I think
this must have a comment explaining why.
Btw, did you try string-collate-lessp instead?
next prev parent reply other threads:[~2019-07-10 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 4:47 bug#33237: 26.1, 7.3 emacs-mac: <fnum> list order in C-h b Van L
2019-07-10 13:36 ` Lars Ingebrigtsen
2019-07-10 15:02 ` Eli Zaretskii [this message]
2019-07-11 14:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838st63pbn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33237@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=van@scratch.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).