From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33237: 26.1, 7.3 emacs-mac: list order in C-h b Date: Wed, 10 Jul 2019 18:02:36 +0300 Message-ID: <838st63pbn.fsf@gnu.org> References: <1905EAD6-8AD3-4ED2-A80B-26DAF98FF08C@scratch.space> <87lfx63tai.fsf@mouse.gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142036"; mail-complaints-to="usenet@blaine.gmane.org" Cc: van@scratch.space, 33237@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 10 17:03:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlE7w-000alf-PC for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 17:03:24 +0200 Original-Received: from localhost ([::1]:34520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlE7v-0002OA-Qn for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Jul 2019 11:03:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33475) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlE7n-0002Mf-Px for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 11:03:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlE7i-0005PE-7Y for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 11:03:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55844) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlE7a-0005FW-2d for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 11:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlE7Z-0006SE-Si for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2019 11:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33237 X-GNU-PR-Package: emacs Original-Received: via spool by 33237-submit@debbugs.gnu.org id=B33237.156277097924802 (code B ref 33237); Wed, 10 Jul 2019 15:03:01 +0000 Original-Received: (at 33237) by debbugs.gnu.org; 10 Jul 2019 15:02:59 +0000 Original-Received: from localhost ([127.0.0.1]:36432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlE7X-0006Ry-0r for submit@debbugs.gnu.org; Wed, 10 Jul 2019 11:02:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlE7V-0006Rm-NL for 33237@debbugs.gnu.org; Wed, 10 Jul 2019 11:02:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hlE7P-0004g4-KE; Wed, 10 Jul 2019 11:02:51 -0400 Original-Received: from [176.228.60.248] (port=4092 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hlE7N-0001E2-D1; Wed, 10 Jul 2019 11:02:51 -0400 In-reply-to: <87lfx63tai.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Wed, 10 Jul 2019 15:36:53 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162647 Archived-At: > From: Lars Ingebrigtsen > Date: Wed, 10 Jul 2019 15:36:53 +0200 > Cc: 33237@debbugs.gnu.org > > help-command > 2C-command > kmacro-start-macro-or-insert-counter > kmacro-end-or-call-macro > menu-bar-open > toggle-frame-fullscreen > clipboard-kill-ring-save > clipboard-yank > clipboard-kill-region > > Looks nicer to me. Does anybody object to this change? > > diff --git a/src/keymap.c b/src/keymap.c > index 2ac3d33460..8c2c209e64 100644 > --- a/src/keymap.c > +++ b/src/keymap.c > @@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb) > if (FIXNUMP (a->event) && !FIXNUMP (b->event)) > return -1; > if (SYMBOLP (a->event) && SYMBOLP (b->event)) > - return (!NILP (Fstring_lessp (a->event, b->event)) ? -1 > - : !NILP (Fstring_lessp (b->event, a->event)) ? 1 > + return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1 > + : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1 > : 0); > return 0; > } It sounds very strange to use string-version-lessp here, so I think this must have a comment explaining why. Btw, did you try string-collate-lessp instead?