From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: abliss@gmail.com, 36591@debbugs.gnu.org
Subject: bug#36591: 26.2; Term's pager seems broken
Date: Tue, 23 Jul 2019 20:40:41 +0300 [thread overview]
Message-ID: <838ssops2u.fsf@gnu.org> (raw)
In-Reply-To: <87lfwox3fi.fsf@gmail.com> (message from Noam Postavsky on Tue, 23 Jul 2019 09:53:37 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Tue, 23 Jul 2019 09:53:37 -0400
> Cc: 36591@debbugs.gnu.org
>
> Adam Bliss <abliss@gmail.com> writes:
>
> > I hope that this is helpful in tracking down the bug.
>
> Thanks for doing this, it was very helpful. That commit looks like a
> pretty innocent refactoring, but it actually reverses the sense of the
> EQ (p->filter, Qt) check, because the pset_filter call is moved earlier.
>
> So the bug can be fixed by adding a single '!'. Eli, any chance of
> having this fix in the release branch?
I don't think I understand why the change fixes the bug, sorry. Can
you tell in more detail? Also, the same function is called in another
place, so what will this change do to that other caller?
And how come we lived with this bug for 3 years without having noticed
it?
next prev parent reply other threads:[~2019-07-23 17:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 0:06 bug#36591: 26.2; Term's pager seems broken Adam Bliss
2019-07-23 13:53 ` Noam Postavsky
2019-07-23 17:40 ` Eli Zaretskii [this message]
2019-07-23 22:33 ` Adam Bliss
2019-07-24 2:07 ` Noam Postavsky
2019-07-24 15:07 ` Eli Zaretskii
2019-07-25 0:55 ` Noam Postavsky
2019-07-25 10:02 ` Lars Ingebrigtsen
2019-07-25 13:01 ` Eli Zaretskii
2019-07-25 16:58 ` Lars Ingebrigtsen
2019-07-25 13:01 ` Noam Postavsky
2019-07-25 17:01 ` Lars Ingebrigtsen
2019-07-25 17:28 ` Noam Postavsky
2019-07-25 17:44 ` Lars Ingebrigtsen
2019-07-25 17:57 ` Noam Postavsky
2019-07-25 13:11 ` Eli Zaretskii
2019-07-25 22:38 ` Noam Postavsky
2020-08-21 12:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838ssops2u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36591@debbugs.gnu.org \
--cc=abliss@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).