From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36591: 26.2; Term's pager seems broken Date: Tue, 23 Jul 2019 20:40:41 +0300 Message-ID: <838ssops2u.fsf@gnu.org> References: <87lfwox3fi.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="88279"; mail-complaints-to="usenet@blaine.gmane.org" Cc: abliss@gmail.com, 36591@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 23 19:42:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpynk-000Mlc-Qd for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2019 19:42:12 +0200 Original-Received: from localhost ([::1]:46342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpyne-0005h8-2a for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jul 2019 13:42:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55745) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpyna-0005fG-VK for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 13:42:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpyna-00032G-28 for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 13:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpynZ-00031a-UF for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 13:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hpynZ-0001Pt-QQ for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2019 13:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2019 17:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36591 X-GNU-PR-Package: emacs Original-Received: via spool by 36591-submit@debbugs.gnu.org id=B36591.15639036635382 (code B ref 36591); Tue, 23 Jul 2019 17:42:01 +0000 Original-Received: (at 36591) by debbugs.gnu.org; 23 Jul 2019 17:41:03 +0000 Original-Received: from localhost ([127.0.0.1]:35585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpymc-0001Ok-TC for submit@debbugs.gnu.org; Tue, 23 Jul 2019 13:41:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpymZ-0001O7-UM for 36591@debbugs.gnu.org; Tue, 23 Jul 2019 13:41:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hpymT-0002F8-LL; Tue, 23 Jul 2019 13:40:54 -0400 Original-Received: from [176.228.60.248] (port=1791 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hpymT-0008J5-5Q; Tue, 23 Jul 2019 13:40:53 -0400 In-reply-to: <87lfwox3fi.fsf@gmail.com> (message from Noam Postavsky on Tue, 23 Jul 2019 09:53:37 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163639 Archived-At: > From: Noam Postavsky > Date: Tue, 23 Jul 2019 09:53:37 -0400 > Cc: 36591@debbugs.gnu.org > > Adam Bliss writes: > > > I hope that this is helpful in tracking down the bug. > > Thanks for doing this, it was very helpful. That commit looks like a > pretty innocent refactoring, but it actually reverses the sense of the > EQ (p->filter, Qt) check, because the pset_filter call is moved earlier. > > So the bug can be fixed by adding a single '!'. Eli, any chance of > having this fix in the release branch? I don't think I understand why the change fixes the bug, sorry. Can you tell in more detail? Also, the same function is called in another place, so what will this change do to that other caller? And how come we lived with this bug for 3 years without having noticed it?