unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Hong Xu <hong@topbug.net>
Cc: 37538@debbugs.gnu.org
Subject: bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'.
Date: Sat, 28 Sep 2019 11:11:58 +0300	[thread overview]
Message-ID: <838sq8j0vl.fsf@gnu.org> (raw)
In-Reply-To: <36bef08c-45b5-9cce-5374-d4de4260d39a@topbug.net> (message from Hong Xu on Sat, 28 Sep 2019 00:59:21 -0700)

> From: Hong Xu <hong@topbug.net>
> Date: Sat, 28 Sep 2019 00:59:21 -0700
> 
> * lisp/progmodes/etags.el (tags-complete-tags-table-file): Add docstring.

Thanks.  A comment below.

> -(defun tags-complete-tags-table-file (string predicate what) ; Doc string?
> +(defun tags-complete-tags-table-file (string predicate what)
> +  "Complete file names in the current tags table.
> +The meaning of the arguments are the same as the function form of
> +COLLECTION as explained in Info node `(elisp) Programmed
> +Completion'."

The first line of the doc string should mention the arguments.  And we
should explain STRING and WHAT there, because those aren't passed to
all-completions and try-completion.






  reply	other threads:[~2019-09-28  8:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28  7:59 bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file' Hong Xu
2019-09-28  8:11 ` Eli Zaretskii [this message]
2019-09-28 18:40   ` Hong Xu
2019-10-07  4:13     ` Lars Ingebrigtsen
2019-10-07 16:18       ` Eli Zaretskii
2019-10-07 17:27         ` Hong Xu
2019-10-08 16:21           ` Lars Ingebrigtsen
2019-10-09  6:39             ` Hong Xu
2019-10-09  8:09               ` Eli Zaretskii
2019-10-09 22:58                 ` Hong Xu
2019-10-10  7:49                   ` Eli Zaretskii
2019-10-12  0:48                     ` Hong Xu
2019-10-12  9:04                       ` Eli Zaretskii
2019-10-12 18:46                         ` Hong Xu
2019-10-12 18:57                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838sq8j0vl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37538@debbugs.gnu.org \
    --cc=hong@topbug.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).