From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37538: [PATCH] Add docstring for `tags-complete-tags-table-file'. Date: Sat, 28 Sep 2019 11:11:58 +0300 Message-ID: <838sq8j0vl.fsf@gnu.org> References: <36bef08c-45b5-9cce-5374-d4de4260d39a@topbug.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="40097"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37538@debbugs.gnu.org To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 28 10:16:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iE7tg-000AJK-Hy for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 10:16:08 +0200 Original-Received: from localhost ([::1]:59484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iE7tf-0001bn-5b for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 04:16:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34498) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iE7qh-0000FI-Rs for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 04:13:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iE7qg-00022q-Or for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 04:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40159) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iE7qg-00022f-MG for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 04:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iE7qg-0005XJ-DZ for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 04:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Sep 2019 08:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37538 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37538-submit@debbugs.gnu.org id=B37538.156965833521224 (code B ref 37538); Sat, 28 Sep 2019 08:13:02 +0000 Original-Received: (at 37538) by debbugs.gnu.org; 28 Sep 2019 08:12:15 +0000 Original-Received: from localhost ([127.0.0.1]:48980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iE7pt-0005WF-I6 for submit@debbugs.gnu.org; Sat, 28 Sep 2019 04:12:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iE7pr-0005W2-K6 for 37538@debbugs.gnu.org; Sat, 28 Sep 2019 04:12:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iE7pm-0001JL-FN; Sat, 28 Sep 2019 04:12:06 -0400 Original-Received: from [176.228.60.248] (port=3815 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iE7pl-0006FV-8j; Sat, 28 Sep 2019 04:12:05 -0400 In-reply-to: <36bef08c-45b5-9cce-5374-d4de4260d39a@topbug.net> (message from Hong Xu on Sat, 28 Sep 2019 00:59:21 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167462 Archived-At: > From: Hong Xu > Date: Sat, 28 Sep 2019 00:59:21 -0700 > > * lisp/progmodes/etags.el (tags-complete-tags-table-file): Add docstring. Thanks. A comment below. > -(defun tags-complete-tags-table-file (string predicate what) ; Doc string? > +(defun tags-complete-tags-table-file (string predicate what) > + "Complete file names in the current tags table. > +The meaning of the arguments are the same as the function form of > +COLLECTION as explained in Info node `(elisp) Programmed > +Completion'." The first line of the doc string should mention the arguments. And we should explain STRING and WHAT there, because those aren't passed to all-completions and try-completion.