unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 47860@debbugs.gnu.org, gregory@heytings.org
Subject: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression
Date: Mon, 19 Apr 2021 20:15:15 +0300	[thread overview]
Message-ID: <838s5eryak.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48x6NYX1h3=0UTCdRHDgyvJOwH9ez2r=OmdYuqSek+ZTEA@mail.gmail.com> (message from Aaron Jensen on Mon, 19 Apr 2021 11:19:06 -0500)

> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Mon, 19 Apr 2021 11:19:06 -0500
> Cc: Gregory Heytings <gregory@heytings.org>, 47860@debbugs.gnu.org
> 
> Okay, here's a selectrum-free repro that, on emacs 27 shows all 3
> lines and on emacs 28 shows only two lines:
> 
> (defun foo--set-window-height (window &optional height)
>   (let ((dheight (or height (cdr (window-text-pixel-size window))))
>         (wheight (window-pixel-height window))
>         (window-resize-pixelwise t))
>     (window-resize
>      window (- dheight wheight) nil nil 'pixelwise)))

Yes, that's the problem: selectrum doesn't rely on the automatic
mini-window resize, it resizes the mini-window manually!  And it
relies on window-text-pixel-size to tell how high should the
mini-window become.

So the root cause is in window-text-pixel-size when this crazy mix of
overlays is used.  Will take a look when I have time.





  reply	other threads:[~2021-04-19 17:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18  1:31 bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression Aaron Jensen
2021-04-18  6:57 ` Eli Zaretskii
2021-04-18 17:45   ` Aaron Jensen
2021-04-18 18:03     ` Eli Zaretskii
2021-04-19  0:15       ` Aaron Jensen
2021-04-19 12:40         ` Gregory Heytings
2021-04-19 13:10           ` Eli Zaretskii
2021-04-19 14:02             ` Aaron Jensen
2021-04-19 14:24               ` Aaron Jensen
2021-04-19 14:43                 ` Eli Zaretskii
2021-04-19 14:48               ` Eli Zaretskii
2021-04-19 15:13                 ` Aaron Jensen
2021-04-19 16:19                   ` Aaron Jensen
2021-04-19 17:15                     ` Eli Zaretskii [this message]
2021-04-19 17:40                       ` Eli Zaretskii
2021-04-22 11:07                         ` Eli Zaretskii
2021-04-22 16:00                           ` Aaron Jensen
2021-04-22 16:50                             ` Eli Zaretskii
2021-04-19 14:48               ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838s5eryak.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=47860@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=gregory@heytings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).