unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 47860@debbugs.gnu.org
Subject: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression
Date: Sun, 18 Apr 2021 09:57:09 +0300	[thread overview]
Message-ID: <835z0kulkq.fsf@gnu.org> (raw)
In-Reply-To: <m2k0p0xtso.fsf@gmail.com> (message from Aaron Jensen on Sat, 17 Apr 2021 20:31:19 -0500)

> From: Aaron Jensen <aaronjensen@gmail.com>
> CC: eliz@gnu.org
> Date: Sat, 17 Apr 2021 20:31:19 -0500
> 
> This is a weird one, but when using selectrum and consult I noticed that
> in some cases the mini buffer does not get properly resized. I tracked
> it down to a recent commit:
> 
> 56c42bd28d9be400e37e122b7abebcd980ea0e8b
> 
> When one of the lines in the minibuffer is truncated, automatically
> resizing the mini buffer does not work properly. Specifically, the
> height is not adjusted to the actual height of the content.
> 
> To reproduce, you'll need selectrum and consult installed, then, from
> emacs -Q:
> 
> (recentf-mode)
> ;; This should be enough x's to cause truncation (so more than your
> ;; window width)
> (setq recentf-list '("xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"))
> (require 'consult)
> (require 'selectrum)
> (selectrum-mode)
> (setq completion-styles '(substring))
> (consult-buffer)
> 
> I expect to see all lines in the minibuffer, including the xxxx..., but
> instead I just see the first couple. Reverting the above commit fixes
> the issue.
> 
> Hopefully this is enough to pinpoint it, but if it's not I can try and
> find a more narrow repro

Yes, please do.  I'd very much prefer to see a recipe that doesn't
involve 3rd-party packages which specifically are aimed at changing
how completion works in the minibuffer.  So, please, no consult and
no selectrum.  Okay?

Thanks.





  reply	other threads:[~2021-04-18  6:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18  1:31 bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression Aaron Jensen
2021-04-18  6:57 ` Eli Zaretskii [this message]
2021-04-18 17:45   ` Aaron Jensen
2021-04-18 18:03     ` Eli Zaretskii
2021-04-19  0:15       ` Aaron Jensen
2021-04-19 12:40         ` Gregory Heytings
2021-04-19 13:10           ` Eli Zaretskii
2021-04-19 14:02             ` Aaron Jensen
2021-04-19 14:24               ` Aaron Jensen
2021-04-19 14:43                 ` Eli Zaretskii
2021-04-19 14:48               ` Eli Zaretskii
2021-04-19 15:13                 ` Aaron Jensen
2021-04-19 16:19                   ` Aaron Jensen
2021-04-19 17:15                     ` Eli Zaretskii
2021-04-19 17:40                       ` Eli Zaretskii
2021-04-22 11:07                         ` Eli Zaretskii
2021-04-22 16:00                           ` Aaron Jensen
2021-04-22 16:50                             ` Eli Zaretskii
2021-04-19 14:48               ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835z0kulkq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=47860@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).