unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: luangruo@yahoo.com, 62234-done@debbugs.gnu.org,
	konrad.podczeck@univie.ac.at
Subject: bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
Date: Thu, 23 Mar 2023 10:10:10 +0200	[thread overview]
Message-ID: <838rfn6g7x.fsf@gnu.org> (raw)
In-Reply-To: <m1a60atky8.fsf@yahoo.es> (message from Daniel Martín on Sat, 18 Mar 2023 11:25:51 +0100)

> From: Daniel Martín <mardani29@yahoo.es>
> Cc: Eli Zaretskii <eliz@gnu.org>,  62234@debbugs.gnu.org,  Konrad Podczeck
>  <konrad.podczeck@univie.ac.at>
> Date: Sat, 18 Mar 2023 11:25:51 +0100
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> >> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
> >> +{
> >> +    return [toolbarItem isEnabled];
> >> +}
> >> +
> >
> > This does no harm on GNUstep.  However, please indent with two spaces,
> > and place spaces after -, :, and ):
> >
> > - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
> > {
> >   return [toolbarItem isEnabled];
> > }
> >
> > Otherwise, LGTM.  Thanks.
> 
> OK, I've attached a new version of the patch.  Konrad, could you check
> if with this patch the Emacs toolbar works as you expect?  Thanks.

Thanks, installed on the emacs-29 branch, and closing the bug.





  parent reply	other threads:[~2023-03-23  8:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  7:55 bug#62234: Toolbar does not work properly (with Emacs 29 or 30) Konrad Podczeck
2023-03-17  8:27 ` Eli Zaretskii
2023-03-17 10:38   ` Konrad Podczeck
2023-03-17 11:49     ` Eli Zaretskii
2023-03-17 13:11       ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 13:32         ` Eli Zaretskii
2023-03-18  0:29         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18  1:09           ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18  3:11             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18 10:25               ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18 11:07                 ` Konrad Podczeck
2023-03-23  8:10                 ` Eli Zaretskii [this message]
2023-03-23 14:57                   ` Konrad Podczeck
2023-03-17 15:21       ` Konrad Podczeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rfn6g7x.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62234-done@debbugs.gnu.org \
    --cc=konrad.podczeck@univie.ac.at \
    --cc=luangruo@yahoo.com \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).