From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62234: Toolbar does not work properly (with Emacs 29 or 30) Date: Thu, 23 Mar 2023 10:10:10 +0200 Message-ID: <838rfn6g7x.fsf@gnu.org> References: <83sfe3eqaf.fsf@gnu.org> <83jzzfegy0.fsf@gnu.org> <87a60a3nrj.fsf@yahoo.com> <871qlm3g9t.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36383"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 62234-done@debbugs.gnu.org, konrad.podczeck@univie.ac.at To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 23 09:11:44 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfG2x-0009F5-TO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Mar 2023 09:11:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfG2L-00082w-BW; Thu, 23 Mar 2023 04:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfG2K-00082M-1f for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 04:11:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfG2I-0000rk-Of for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 04:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfG2I-0004jV-K3 for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 04:11:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Mar 2023 08:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62234 X-GNU-PR-Package: emacs Mail-Followup-To: 62234@debbugs.gnu.org, eliz@gnu.org, konrad.podczeck@univie.ac.at Original-Received: via spool by 62234-done@debbugs.gnu.org id=D62234.167955900418088 (code D ref 62234); Thu, 23 Mar 2023 08:11:02 +0000 Original-Received: (at 62234-done) by debbugs.gnu.org; 23 Mar 2023 08:10:04 +0000 Original-Received: from localhost ([127.0.0.1]:37258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfG1M-0004hg-9M for submit@debbugs.gnu.org; Thu, 23 Mar 2023 04:10:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfG1K-0004h6-5o for 62234-done@debbugs.gnu.org; Thu, 23 Mar 2023 04:10:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfG1C-0000Om-QO; Thu, 23 Mar 2023 04:09:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wOHJIVKXUAy+jm1W/H3rKRnZAQhO5S6flDVy5s6JI1M=; b=KSLYj9dKqLzrQfdg1qLy paqw6Vwxs5eTzR5JImzinHHknuA3msH7lrCrRpcapV6obi/akBTRVttlBVd/Jdqp++8MDDudjIlP8 yF3r+ZvJQT+FuyX8iiCKr+mccaWZF+hqulJk+uNJ4CaG3h1jmrqL40lDNx88LXoSOTyopJcFuYoL+ 9wRqTeAJOACvUe8Mx53/s3haWoQigO3+cleWWe67EMHg+OJSHTiU3YhOPH/qIxRaf1bN03cTCf2uK GTonGUYPVeuu+gto28MPWT6ENaQ2Jy8XPKGJwQdfLL2N1te/ayT8x+oNnQyNPs8dNTo3RyclDPZ+k O9gvlZVjFyUFbA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfG1C-0007WQ-1P; Thu, 23 Mar 2023 04:09:54 -0400 In-Reply-To: (message from Daniel =?UTF-8?Q?Mart=C3=ADn?= on Sat, 18 Mar 2023 11:25:51 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258444 Archived-At: > From: Daniel Martín > Cc: Eli Zaretskii , 62234@debbugs.gnu.org, Konrad Podczeck > > Date: Sat, 18 Mar 2023 11:25:51 +0100 > > Po Lu writes: > > >> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem > >> +{ > >> + return [toolbarItem isEnabled]; > >> +} > >> + > > > > This does no harm on GNUstep. However, please indent with two spaces, > > and place spaces after -, :, and ): > > > > - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem > > { > > return [toolbarItem isEnabled]; > > } > > > > Otherwise, LGTM. Thanks. > > OK, I've attached a new version of the patch. Konrad, could you check > if with this patch the Emacs toolbar works as you expect? Thanks. Thanks, installed on the emacs-29 branch, and closing the bug.