unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Jason Rumney <jasonr@gnu.org>
Cc: claudio.bley@gmail.com, 9087@debbugs.gnu.org, lekktu@gmail.com
Subject: bug#9087: Crash reading from minibuffer with icomplete-mode
Date: Sat, 07 Jan 2012 10:31:48 +0200	[thread overview]
Message-ID: <837h13hq17.fsf@gnu.org> (raw)
In-Reply-To: <jwvlipke44b.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: rudalics@gmx.at,  claudio.bley@gmail.com,  lekktu@gmail.com,  9087@debbugs.gnu.org
> Date: Fri, 06 Jan 2012 19:42:24 -0500
> 
> > I can avoid the crash with the patch below.  But it defers the
> > throwing until Emacs is done whatever it was doing (in this case,
> > evaluating byte code).  Is this acceptable?
> 
> Is a C-g also delayed in a similar way under w32?

Yes, it is, at least in this case.  The only difference between
handling of throw-on-input and C-g on Windows is that the latter can
also interrupt prolonged system calls.  But throw-on-input is not
supposed to do that, right?  And we are not in a system call in this
case, we are just in a long calculation done by byte code.

Jason, could you please chime in?  signal_user_input was written by
you.  Doing a QUIT from a thread other than the Lisp evaluation thread
is clearly not TRT, I think, so it must be taken out.  The question
is: is there some way we can honor immediate_quit here, or should we
just ignore it?  TIA.

(Once again, why isn't throw-on-input documented?  With only a short
doc string lacking any details, I have no way of knowing what exactly
its contract is.)





  reply	other threads:[~2012-01-07  8:31 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 22:54 bug#9087: Crash reading from minibuffer with icomplete-mode Juanma Barranquero
2011-07-15  7:30 ` martin rudalics
2011-07-15 12:12   ` Juanma Barranquero
2011-07-15 12:23     ` martin rudalics
2011-07-15 16:40       ` Juanma Barranquero
2011-07-15 11:13 ` Eli Zaretskii
2011-07-15 12:11   ` Juanma Barranquero
2011-07-15 12:15     ` Juanma Barranquero
2011-07-15 12:29     ` Eli Zaretskii
2011-07-15 15:12       ` Juanma Barranquero
2011-07-15 15:24         ` Eli Zaretskii
2011-07-15 16:39           ` Juanma Barranquero
2011-07-15 17:12             ` Eli Zaretskii
2011-07-16 23:19           ` Juanma Barranquero
2011-07-17  3:08             ` Eli Zaretskii
2011-07-18  2:07               ` Juanma Barranquero
2011-07-18  3:01                 ` Eli Zaretskii
2011-07-18 11:53                   ` Juanma Barranquero
2011-07-18 16:45                     ` Eli Zaretskii
2011-07-18 17:34                       ` Juanma Barranquero
2011-07-17  9:38             ` martin rudalics
2011-07-18  1:59               ` Juanma Barranquero
2011-08-14 20:13     ` Chong Yidong
2011-09-14 14:43       ` Juanma Barranquero
2012-01-01 20:56         ` Claudio Bley
2012-01-01 21:24           ` Juanma Barranquero
2012-01-01 21:43           ` Eli Zaretskii
2012-01-02 16:16             ` Claudio Bley
2012-01-04 15:44               ` Claudio Bley
2012-01-06 10:02               ` Eli Zaretskii
2012-01-06 12:48                 ` Juanma Barranquero
2012-01-06 13:19                   ` martin rudalics
2012-01-06 13:26                     ` Juanma Barranquero
2012-01-06 15:17                   ` Eli Zaretskii
2012-01-06 16:07                     ` martin rudalics
2012-01-06 19:01                       ` Eli Zaretskii
2012-01-06 19:45                         ` martin rudalics
2012-01-06 19:53                           ` Eli Zaretskii
2012-01-06 20:50                             ` Eli Zaretskii
2012-01-06 22:34                               ` Juanma Barranquero
2012-01-07  0:42                               ` Stefan Monnier
2012-01-07  8:31                                 ` Eli Zaretskii [this message]
2012-01-07 10:11                                   ` martin rudalics
2012-01-07 10:49                                     ` Eli Zaretskii
2012-01-07 11:51                                       ` martin rudalics
2012-01-07 12:21                                         ` Eli Zaretskii
2012-01-07 13:57                                           ` martin rudalics
2012-01-07 14:59                                             ` Eli Zaretskii
2012-01-07 16:27                                               ` martin rudalics
2012-01-07 17:05                                                 ` Eli Zaretskii
2012-01-07 17:17                                                   ` martin rudalics
2012-01-07 17:31                                                     ` Eli Zaretskii
2012-01-07 17:45                                                       ` martin rudalics
2012-01-07 17:52                                                         ` Eli Zaretskii
2012-01-07 13:12                                         ` Andreas Schwab
2012-01-07 13:57                                           ` martin rudalics
2012-01-07 15:00                                             ` Eli Zaretskii
2012-01-07 18:21                                   ` Stefan Monnier
2012-01-07 18:59                                     ` Eli Zaretskii
2012-01-08 14:01                                       ` Stefan Monnier
2012-01-14 20:16                                     ` Eli Zaretskii
2012-01-07 10:10                               ` martin rudalics
2012-01-07 10:58                                 ` Eli Zaretskii
2012-01-07 11:52                                   ` martin rudalics
2012-01-07 12:11                                     ` Eli Zaretskii
2012-01-07 13:55                                       ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837h13hq17.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=9087@debbugs.gnu.org \
    --cc=claudio.bley@gmail.com \
    --cc=jasonr@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).