From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9087: Crash reading from minibuffer with icomplete-mode Date: Sat, 07 Jan 2012 10:31:48 +0200 Message-ID: <837h13hq17.fsf@gnu.org> References: <83zkkfhk4c.fsf@gnu.org> <871uwng399.fsf@stupidchicken.com> <87obunjg5w.wl%claudio.bley@gmail.com> <83vcovqeu2.fsf@gnu.org> <84ty4ef5ap.wl%claudio.bley@gmail.com> <83vcopno6r.fsf@gnu.org> <83lipkoo60.fsf@gnu.org> <4F071C36.9020401@gmx.at> <83aa60odt9.fsf@gnu.org> <4F074F3F.9030502@gmx.at> <8362goobf6.fsf@gnu.org> <831urco8rt.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1325925133 10025 80.91.229.12 (7 Jan 2012 08:32:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 7 Jan 2012 08:32:13 +0000 (UTC) Cc: claudio.bley@gmail.com, 9087@debbugs.gnu.org, lekktu@gmail.com To: Stefan Monnier , Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 07 09:32:08 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RjRh8-0004t8-D9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2012 09:32:06 +0100 Original-Received: from localhost ([::1]:38871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjRh7-0003oD-VV for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2012 03:32:05 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:41671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjRh5-0003o5-2E for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2012 03:32:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjRh3-0002kL-Kh for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2012 03:32:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjRh3-0002kG-Hv for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2012 03:32:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RjRh4-0005Bp-2I for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2012 03:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2012 08:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9087 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9087-submit@debbugs.gnu.org id=B9087.132592512119942 (code B ref 9087); Sat, 07 Jan 2012 08:32:02 +0000 Original-Received: (at 9087) by debbugs.gnu.org; 7 Jan 2012 08:32:01 +0000 Original-Received: from localhost ([127.0.0.1]:47699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjRh2-0005Ba-Qi for submit@debbugs.gnu.org; Sat, 07 Jan 2012 03:32:01 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:59351) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RjRh0-0005BO-T8 for 9087@debbugs.gnu.org; Sat, 07 Jan 2012 03:31:59 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LXF00B0061ZEV00@a-mtaout22.012.net.il> for 9087@debbugs.gnu.org; Sat, 07 Jan 2012 10:31:51 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.156.26]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LXF00AK56D0PAM0@a-mtaout22.012.net.il>; Sat, 07 Jan 2012 10:31:50 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55490 Archived-At: > From: Stefan Monnier > Cc: rudalics@gmx.at, claudio.bley@gmail.com, lekktu@gmail.com, 9087@debbugs.gnu.org > Date: Fri, 06 Jan 2012 19:42:24 -0500 > > > I can avoid the crash with the patch below. But it defers the > > throwing until Emacs is done whatever it was doing (in this case, > > evaluating byte code). Is this acceptable? > > Is a C-g also delayed in a similar way under w32? Yes, it is, at least in this case. The only difference between handling of throw-on-input and C-g on Windows is that the latter can also interrupt prolonged system calls. But throw-on-input is not supposed to do that, right? And we are not in a system call in this case, we are just in a long calculation done by byte code. Jason, could you please chime in? signal_user_input was written by you. Doing a QUIT from a thread other than the Lisp evaluation thread is clearly not TRT, I think, so it must be taken out. The question is: is there some way we can honor immediate_quit here, or should we just ignore it? TIA. (Once again, why isn't throw-on-input documented? With only a short doc string lacking any details, I have no way of knowing what exactly its contract is.)