unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#24843: 25.1; docstring of 'browse-url-firefox-new-window-is-tab' contains obsolete remark
@ 2016-11-01  0:51 Tibor Csögör
  2016-11-04  9:26 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Tibor Csögör @ 2016-11-01  0:51 UTC (permalink / raw)
  To: 24843

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

The docstring states: "This option is currently ignored on MS-Windows, since the
necessary functionality is not available there."  However, this limitation was
removed in commit 20c6b227ea69b9cd47f92d1a7e0935312e8ce83c.

Patch attached.


Fix docstring of 'browse-url-firefox-new-window-is-tab'

* lisp/net/browse-url.el (browse-url-firefox-new-window-is-tab): Remove
obsolete remark from docstring (obsoleted by commit
20c6b227ea69b9cd47f92d1a7e0935312e8ce83c). (Bug#XXXXX)


[-- Attachment #2: 0001-Fix-docstring-of-browse-url-firefox-new-window-is-ta.patch --]
[-- Type: text/plain, Size: 1222 bytes --]

From 48df60f57a218b4c82eabbfa312141d5dc88d194 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tibor=20Cs=C3=B6g=C3=B6r?= <tibi@tiborius.net>
Date: Tue, 1 Nov 2016 01:38:07 +0100
Subject: [PATCH] Fix docstring of 'browse-url-firefox-new-window-is-tab'

* lisp/net/browse-url.el (browse-url-firefox-new-window-is-tab): Remove
obsolete remark from docstring (obsoleted by commit
20c6b227ea69b9cd47f92d1a7e0935312e8ce83c). (Bug#XXXXX)
---
 lisp/net/browse-url.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index 1bb4831..15f6df7 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -365,10 +365,7 @@ If non-nil, then open the URL in a new tab rather than a new window if
 (defcustom browse-url-firefox-new-window-is-tab nil
   "Whether to open up new windows in a tab or a new window.
 If non-nil, then open the URL in a new tab rather than a new window if
-`browse-url-firefox' is asked to open it in a new window.
-
-This option is currently ignored on MS-Windows, since the necessary
-functionality is not available there."
+`browse-url-firefox' is asked to open it in a new window."
   :type 'boolean
   :group 'browse-url)
 
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#24843: 25.1; docstring of 'browse-url-firefox-new-window-is-tab' contains obsolete remark
  2016-11-01  0:51 bug#24843: 25.1; docstring of 'browse-url-firefox-new-window-is-tab' contains obsolete remark Tibor Csögör
@ 2016-11-04  9:26 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2016-11-04  9:26 UTC (permalink / raw)
  To: Tibor Csögör; +Cc: 24843-done

> From: Tibor Csögör <tibi@tiborius.net>
> Date: Tue, 01 Nov 2016 01:51:45 +0100
> 
> The docstring states: "This option is currently ignored on MS-Windows, since the
> necessary functionality is not available there."  However, this limitation was
> removed in commit 20c6b227ea69b9cd47f92d1a7e0935312e8ce83c.
> 
> Patch attached.

Thanks, pushed to the emacs-25 branch.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-04  9:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-01  0:51 bug#24843: 25.1; docstring of 'browse-url-firefox-new-window-is-tab' contains obsolete remark Tibor Csögör
2016-11-04  9:26 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).