From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>, martin rudalics <rudalics@gmx.at>
Cc: bluetrack121@gmail.com, 43645@debbugs.gnu.org
Subject: bug#43645: 26.3; emacsclient -c does not open to correct window
Date: Mon, 28 Sep 2020 16:43:20 +0300 [thread overview]
Message-ID: <837dsem2yv.fsf@gnu.org> (raw)
In-Reply-To: <87r1qmujmn.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 28 Sep 2020 15:16:16 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 28 Sep 2020 15:16:16 +0200
> Cc: 43645@debbugs.gnu.org
>
> This patch fixes the problem, but I'm hesitating to apply it even if it
> looks kinda-sorta "obviously correct": It changes the logic to only
> check whether the buffer is displayed in the current frame, which makes
> emacsclient -c work. But why was the all-frame argument added? It's
> been there since at least the 90s...
>
> I can't see any adverse affects on emacsclient -t either.
>
> Anybody with any insight here?
>
> diff --git a/lisp/server.el b/lisp/server.el
> index 436a6ca0c7..f24f8d2b7c 100644
> --- a/lisp/server.el
> +++ b/lisp/server.el
> @@ -1602,7 +1602,7 @@ server-switch-buffer
> ;; OK, we know next-buffer is live, let's display and select it.
> (if (functionp server-window)
> (funcall server-window next-buffer)
> - (let ((win (get-buffer-window next-buffer 0)))
> + (let ((win (get-buffer-window next-buffer)))
> (if (and win (not server-window))
> ;; The buffer is already displayed: just reuse the
> ;; window. If FILEPOS is non-nil, use it to replace the
>
Martin, any comments on this?
Thanks.
next prev parent reply other threads:[~2020-09-28 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 6:41 bug#43645: 26.3; emacsclient -c does not open to correct window Blue track
2020-09-27 9:58 ` Eli Zaretskii
2020-09-27 10:36 ` Blue track
2020-09-27 10:54 ` Eli Zaretskii
2020-09-27 16:02 ` Lars Ingebrigtsen
2020-09-27 16:09 ` Eli Zaretskii
2020-09-27 16:21 ` Lars Ingebrigtsen
2020-09-27 16:33 ` Eli Zaretskii
2020-09-27 16:44 ` Lars Ingebrigtsen
2020-09-27 16:49 ` Eli Zaretskii
2020-09-28 13:16 ` Lars Ingebrigtsen
2020-09-28 13:43 ` Eli Zaretskii [this message]
2020-09-28 15:02 ` martin rudalics
2020-09-29 14:06 ` Eli Zaretskii
2020-09-29 14:09 ` Lars Ingebrigtsen
2020-09-29 14:22 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837dsem2yv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=43645@debbugs.gnu.org \
--cc=bluetrack121@gmail.com \
--cc=larsi@gnus.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).