From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43645: 26.3; emacsclient -c does not open to correct window Date: Mon, 28 Sep 2020 16:43:20 +0300 Message-ID: <837dsem2yv.fsf@gnu.org> References: <87r1qmujmn.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11199"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bluetrack121@gmail.com, 43645@debbugs.gnu.org To: Lars Ingebrigtsen , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 28 15:57:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMtei-0002kw-Nz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Sep 2020 15:57:28 +0200 Original-Received: from localhost ([::1]:59380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMteh-0007FO-OF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Sep 2020 09:57:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMtRh-0001HB-U2 for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 09:44:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMtRh-0005vt-Ku for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 09:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMtRh-0003tR-Is for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2020 09:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Sep 2020 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43645 X-GNU-PR-Package: emacs Original-Received: via spool by 43645-submit@debbugs.gnu.org id=B43645.160130062314930 (code B ref 43645); Mon, 28 Sep 2020 13:44:01 +0000 Original-Received: (at 43645) by debbugs.gnu.org; 28 Sep 2020 13:43:43 +0000 Original-Received: from localhost ([127.0.0.1]:51926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMtRO-0003sk-U1 for submit@debbugs.gnu.org; Mon, 28 Sep 2020 09:43:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMtRM-0003sX-HR for 43645@debbugs.gnu.org; Mon, 28 Sep 2020 09:43:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43099) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMtRF-0005tn-5A; Mon, 28 Sep 2020 09:43:33 -0400 Original-Received: from [176.228.60.248] (port=3387 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kMtRE-0000sb-DW; Mon, 28 Sep 2020 09:43:32 -0400 In-Reply-To: <87r1qmujmn.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 28 Sep 2020 15:16:16 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189202 Archived-At: > From: Lars Ingebrigtsen > Date: Mon, 28 Sep 2020 15:16:16 +0200 > Cc: 43645@debbugs.gnu.org > > This patch fixes the problem, but I'm hesitating to apply it even if it > looks kinda-sorta "obviously correct": It changes the logic to only > check whether the buffer is displayed in the current frame, which makes > emacsclient -c work. But why was the all-frame argument added? It's > been there since at least the 90s... > > I can't see any adverse affects on emacsclient -t either. > > Anybody with any insight here? > > diff --git a/lisp/server.el b/lisp/server.el > index 436a6ca0c7..f24f8d2b7c 100644 > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -1602,7 +1602,7 @@ server-switch-buffer > ;; OK, we know next-buffer is live, let's display and select it. > (if (functionp server-window) > (funcall server-window next-buffer) > - (let ((win (get-buffer-window next-buffer 0))) > + (let ((win (get-buffer-window next-buffer))) > (if (and win (not server-window)) > ;; The buffer is already displayed: just reuse the > ;; window. If FILEPOS is non-nil, use it to replace the > Martin, any comments on this? Thanks.