unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 50041@debbugs.gnu.org
Subject: bug#50041: Add font-lock-doc-markup-face
Date: Fri, 13 Aug 2021 16:08:11 +0300	[thread overview]
Message-ID: <837dgpcx1g.fsf@gnu.org> (raw)
In-Reply-To: <EA330445-BA21-4C4C-AFF7-020C2ACEE212@acm.org> (message from Mattias Engdegård on Fri, 13 Aug 2021 12:53:04 +0200)

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Fri, 13 Aug 2021 12:53:04 +0200
> 
> Add a standard face for mark-up syntax and keywords inside code documentation (doc comments/strings) whose body text is typically set in font-lock-doc-face. This could include various tags, brackets, quotes, keywords or other syntactically special characters.
> 
> Justification:
> 
> - A standard face means that users and theme authors can set it once for all modes needing it.
> - Having a face that harmonises with font-lock-doc-face reduces the risk of bad ergonomics and aesthetics.
> - Setting doc mark-up in a distinct face makes in-source documentation more readable.
> - It also aids writing documentation by providing feed-back to the programmer in the same way as fontifying regular language constructs.
> 
> The CC modes have the foresight of already using `font-lock-doc-markup-face` if defined, anticipating its eventual addition, defaulting to `font-lock-constant-face`. I therefore propose that the new face will inherit from `font-lock-constant-face` by default.

Which one of these justifies having these faces in font-lock.el, as
opposed in markdown mode itself, or in rst.el?  It is unusual to have
mode-specific faces in a general-purpose Lisp file, let alone a
preloaded one.





  parent reply	other threads:[~2021-08-13 13:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 10:53 bug#50041: Add font-lock-doc-markup-face Mattias Engdegård
2021-08-13 12:15 ` Lars Ingebrigtsen
2021-08-13 13:08 ` Eli Zaretskii [this message]
2021-08-13 14:08   ` Mattias Engdegård
2021-08-13 14:12     ` Eli Zaretskii
2021-08-13 14:34       ` Mattias Engdegård
2021-08-13 15:57         ` Eli Zaretskii
2021-08-13 17:41           ` Mattias Engdegård
2021-08-13 18:31             ` Eli Zaretskii
2021-08-13 21:24               ` Mattias Engdegård
2021-08-14  5:56                 ` Eli Zaretskii
2021-08-14  9:01                   ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837dgpcx1g.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=50041@debbugs.gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).