From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50041: Add font-lock-doc-markup-face Date: Fri, 13 Aug 2021 16:08:11 +0300 Message-ID: <837dgpcx1g.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50041@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 13 15:09:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEWvs-0001Y3-Rq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Aug 2021 15:09:08 +0200 Original-Received: from localhost ([::1]:46008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEWvr-0007QP-Rg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Aug 2021 09:09:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEWvm-0007QG-4n for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 09:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEWvl-000669-Uf for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 09:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mEWvl-0005FX-Pn for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 09:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Aug 2021 13:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50041 X-GNU-PR-Package: emacs Original-Received: via spool by 50041-submit@debbugs.gnu.org id=B50041.162886013220160 (code B ref 50041); Fri, 13 Aug 2021 13:09:01 +0000 Original-Received: (at 50041) by debbugs.gnu.org; 13 Aug 2021 13:08:52 +0000 Original-Received: from localhost ([127.0.0.1]:40848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEWvb-0005F6-Pb for submit@debbugs.gnu.org; Fri, 13 Aug 2021 09:08:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEWvW-0005Em-6Q for 50041@debbugs.gnu.org; Fri, 13 Aug 2021 09:08:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42186) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEWvQ-0005zQ-GH; Fri, 13 Aug 2021 09:08:40 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3713 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEWvO-0000E0-27; Fri, 13 Aug 2021 09:08:40 -0400 In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 13 Aug 2021 12:53:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211758 Archived-At: > From: Mattias Engdegård > Date: Fri, 13 Aug 2021 12:53:04 +0200 > > Add a standard face for mark-up syntax and keywords inside code documentation (doc comments/strings) whose body text is typically set in font-lock-doc-face. This could include various tags, brackets, quotes, keywords or other syntactically special characters. > > Justification: > > - A standard face means that users and theme authors can set it once for all modes needing it. > - Having a face that harmonises with font-lock-doc-face reduces the risk of bad ergonomics and aesthetics. > - Setting doc mark-up in a distinct face makes in-source documentation more readable. > - It also aids writing documentation by providing feed-back to the programmer in the same way as fontifying regular language constructs. > > The CC modes have the foresight of already using `font-lock-doc-markup-face` if defined, anticipating its eventual addition, defaulting to `font-lock-constant-face`. I therefore propose that the new face will inherit from `font-lock-constant-face` by default. Which one of these justifies having these faces in font-lock.el, as opposed in markdown mode itself, or in rst.el? It is unusual to have mode-specific faces in a general-purpose Lisp file, let alone a preloaded one.