From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: 61613@debbugs.gnu.org
Subject: bug#61613: 30.0.50; ffap-other-window ignores ffap-require-prefix
Date: Sun, 19 Feb 2023 11:21:02 +0200 [thread overview]
Message-ID: <837cwexb7l.fsf@gnu.org> (raw)
In-Reply-To: <87pma6tlth.fsf@aol.com> (bug-gnu-emacs@gnu.org)
> Date: Sun, 19 Feb 2023 03:45:30 +0100
> From: Ergus via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I just found that ffap-other-window ignores when ffap-require-prefix is
> non-nil.
>
> Looking at the code it seems to be that find-file-at-point has:
>
> (and (called-interactively-p 'interactive)
> (if ffap-require-prefix (not current-prefix-arg)
> current-prefix-arg))
>
> but ffap-other-window calls find-file-at-point no interactively. Same
> for ffap-other-frame, ffap-other-tab and so on...
What would be the point of supporting ffap-require-prefix when you
call ffap-other-window? That variable controls whether to invoke
ffap-file-finder, which is not suitable for -other-window commands, I
think? That is why, AFAIU, when not called interactively,
find-file-at-point doesn't call ffap-file-finder at all, and therefore
there's no point in heeding ffap-require-prefix. Right?
next prev parent reply other threads:[~2023-02-19 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87pma6tlth.fsf.ref@aol.com>
2023-02-19 2:45 ` bug#61613: 30.0.50; ffap-other-window ignores ffap-require-prefix Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 9:21 ` Eli Zaretskii [this message]
2023-02-19 10:09 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 10:15 ` Eli Zaretskii
2023-02-19 21:32 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 12:50 ` Eli Zaretskii
2023-02-20 15:49 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 17:01 ` Eli Zaretskii
2023-02-19 21:43 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 12:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837cwexb7l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61613@debbugs.gnu.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).