From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61613: 30.0.50; ffap-other-window ignores ffap-require-prefix Date: Sun, 19 Feb 2023 11:21:02 +0200 Message-ID: <837cwexb7l.fsf@gnu.org> References: <87pma6tlth.fsf.ref@aol.com> <87pma6tlth.fsf@aol.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11611"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61613@debbugs.gnu.org To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 19 10:22:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTftj-0002tb-RH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Feb 2023 10:22:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTftT-0004z3-Pu; Sun, 19 Feb 2023 04:22:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTftS-0004ye-R4 for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 04:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTftS-0000e4-I9 for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 04:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTftS-0005aT-DN for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 04:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Feb 2023 09:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61613 X-GNU-PR-Package: emacs Original-Received: via spool by 61613-submit@debbugs.gnu.org id=B61613.167679846921404 (code B ref 61613); Sun, 19 Feb 2023 09:22:02 +0000 Original-Received: (at 61613) by debbugs.gnu.org; 19 Feb 2023 09:21:09 +0000 Original-Received: from localhost ([127.0.0.1]:45678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTfsa-0005ZA-MO for submit@debbugs.gnu.org; Sun, 19 Feb 2023 04:21:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTfsV-0005YB-VX for 61613@debbugs.gnu.org; Sun, 19 Feb 2023 04:21:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTfsQ-0000O0-9x; Sun, 19 Feb 2023 04:20:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tdXzZLPbTbK3M4P6Gz2NotGnLjdE6JkxTmK+ELYZaCc=; b=j2pUYNwaaVZT g8oDMGbsPnlCZjVj1v8VAVf6CHocA0TSVW6xgdiXaRsaHUq9QFafjvBMO0C882uJVk5NPa5sgcBev 0Q7uC3msRHDbgUZZdg2tS3KemPMsJO/j9kQCjdSMHIotk16sJLghq6PSitLgibFnMPV1lnIO7Hv9V 8bFIsQqb6EMRT0g6d9RoKQ/crejBgk0VLPAlrfwNNoRbHtiSkasYxO8g6pZSQIidR7OEq06hAa7Rd Ba1uuWqId8kuV5dlyQ1+dTF3j98xDI66zLHL8tF4iU3IDzum8vxSgrKX7IFFvqmoNlIYUSyQDX5lk Y4Yme6Tsz4xUtyi7OqCRUQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTfsP-0000Ry-EE; Sun, 19 Feb 2023 04:20:57 -0500 In-Reply-To: <87pma6tlth.fsf@aol.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256039 Archived-At: > Date: Sun, 19 Feb 2023 03:45:30 +0100 > From: Ergus via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I just found that ffap-other-window ignores when ffap-require-prefix is > non-nil. > > Looking at the code it seems to be that find-file-at-point has: > > (and (called-interactively-p 'interactive) > (if ffap-require-prefix (not current-prefix-arg) > current-prefix-arg)) > > but ffap-other-window calls find-file-at-point no interactively. Same > for ffap-other-frame, ffap-other-tab and so on... What would be the point of supporting ffap-require-prefix when you call ffap-other-window? That variable controls whether to invoke ffap-file-finder, which is not suitable for -other-window commands, I think? That is why, AFAIU, when not called interactively, find-file-at-point doesn't call ffap-file-finder at all, and therefore there's no point in heeding ffap-require-prefix. Right?