unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Charles El Hourani <charlie.eh@gmail.com>
Cc: 10607@debbugs.gnu.org
Subject: bug#10607: bug-10607
Date: Wed, 05 Apr 2023 07:45:57 +0300	[thread overview]
Message-ID: <837curszqy.fsf@gnu.org> (raw)
In-Reply-To: <CAAB1LQWCUj_eR+5QjyOOH1ohtzKmmqP861Z-5uRG7DJmrY=tdA@mail.gmail.com> (message from Charles El Hourani on Tue, 4 Apr 2023 21:52:39 +0300)

> From: Charles El Hourani <charlie.eh@gmail.com>
> Date: Tue, 4 Apr 2023 21:52:39 +0300
> 
> Here is a way to solve the issue by calling `ls` directly, without re-implementing the "-b" functionality of ls in
> elisp.
> 
> From 22962ffd84370ac05017ed05cca88286d010aa0e Mon Sep 17 00:00:00 2001
> From: Charlie El Hourani <charlie.eh@gmail.com>
> Date: Tue, 4 Apr 2023 21:26:07 +0300
> Subject: [PATCH] Fix dired goto file when -b is provided to ls (bug#10607)
> 
> This fixes the goto file in dired mode for:
> - files containing a control character
> - and when dired uses ls with the "-b" flag
> 
> The goto file function calls 'ls' to give it the escaped name.

Thanks, but is it really a good idea to invoke a program each time we
move in Dired?  dired-goto-file is a function that is used very
frequently.

In any case, calling literally "ls" is not TRT, IMO, since the user
could have modified the value of insert-directory-program.





  reply	other threads:[~2023-04-05  4:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6o62fzm010.fsf@fencepost.gnu.org>
2021-01-20 17:41 ` bug#10607: Handle all the escapes used by ls -b Lars Ingebrigtsen
2023-04-04 18:52 ` bug#10607: bug-10607 Charles El Hourani
2023-04-05  4:45   ` Eli Zaretskii [this message]
2023-04-06 16:45     ` Charles El Hourani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837curszqy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=10607@debbugs.gnu.org \
    --cc=charlie.eh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).