* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
@ 2023-05-24 3:48 Brian Leung
2023-05-24 10:09 ` Mattias Engdegård
0 siblings, 1 reply; 10+ messages in thread
From: Brian Leung @ 2023-05-24 3:48 UTC (permalink / raw)
To: 63674; +Cc: akrl
After the latest changes to native compilation, I see a failure here: https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-24 3:48 bug#63674: 30.0.50; Possible miscompilation of cl-structs? Brian Leung
@ 2023-05-24 10:09 ` Mattias Engdegård
2023-05-24 10:39 ` Brian Leung
2023-05-24 13:18 ` Andrea Corallo
0 siblings, 2 replies; 10+ messages in thread
From: Mattias Engdegård @ 2023-05-24 10:09 UTC (permalink / raw)
To: Brian Leung; +Cc: 63674, Andrea Corallo
> After the latest changes to native compilation, I see a failure here:
> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
CC:ing Andrea.
Could you help him by explaining exactly what we are looking at here? What Emacs revision is this based on, and from what revision is it a regression?
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-24 10:09 ` Mattias Engdegård
@ 2023-05-24 10:39 ` Brian Leung
2023-05-25 0:09 ` Brian Leung
2023-05-24 13:18 ` Andrea Corallo
1 sibling, 1 reply; 10+ messages in thread
From: Brian Leung @ 2023-05-24 10:39 UTC (permalink / raw)
To: Mattias Engdegård; +Cc: 63674, Andrea Corallo
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>> After the latest changes to native compilation, I see a failure
>> here:
>> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
>
> CC:ing Andrea.
>
> Could you help him by explaining exactly what we are looking at
> here? What Emacs revision is this based on, and from what
> revision is it a regression?
This error occurs after Emacs commit
9ad997cd68981fe6c6933b6977fdae23e84e6a75 (see
https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:2657). Our
last successful run used Emacs commit
d4ff1d74209e97730c52ddd50c4d643c79087a33.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-24 10:09 ` Mattias Engdegård
2023-05-24 10:39 ` Brian Leung
@ 2023-05-24 13:18 ` Andrea Corallo
2023-05-24 15:27 ` Andrea Corallo
2023-05-27 6:41 ` Eli Zaretskii
1 sibling, 2 replies; 10+ messages in thread
From: Andrea Corallo @ 2023-05-24 13:18 UTC (permalink / raw)
To: Mattias Engdegård; +Cc: Brian Leung, 63674
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>> After the latest changes to native compilation, I see a failure here:
>> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
>
> CC:ing Andrea.
Thanks, will look at as soon as I can.
PS I merged 63679 63679 63681 as I believe are the same.
Best Regards
Andrea
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-24 13:18 ` Andrea Corallo
@ 2023-05-24 15:27 ` Andrea Corallo
2023-05-27 6:41 ` Eli Zaretskii
1 sibling, 0 replies; 10+ messages in thread
From: Andrea Corallo @ 2023-05-24 15:27 UTC (permalink / raw)
To: Mattias Engdegård; +Cc: Brian Leung, 63674, Stefan Monnier
Andrea Corallo <akrl@sdf.org> writes:
> Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>
>>> After the latest changes to native compilation, I see a failure here:
>>> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
>>
>> CC:ing Andrea.
>
> Thanks, will look at as soon as I can.
>
> PS I merged 63679 63679 63681 as I believe are the same.
>
> Best Regards
>
> Andrea
Okay I've just pushed b2b2be98da5 to fix this.
Essentially the native compiler needs `cl-typep' to be functional at
compile time for the types being defined in the compiled code.
It works for me, let's see if the fix is acceptable.
Thanks
Andrea
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-24 10:39 ` Brian Leung
@ 2023-05-25 0:09 ` Brian Leung
0 siblings, 0 replies; 10+ messages in thread
From: Brian Leung @ 2023-05-25 0:09 UTC (permalink / raw)
To: 63674-done; +Cc: Andrea Corallo
Thanks for the quick fix.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-24 13:18 ` Andrea Corallo
2023-05-24 15:27 ` Andrea Corallo
@ 2023-05-27 6:41 ` Eli Zaretskii
2023-05-28 8:31 ` Andrea Corallo
2023-05-28 10:42 ` Andrea Corallo
1 sibling, 2 replies; 10+ messages in thread
From: Eli Zaretskii @ 2023-05-27 6:41 UTC (permalink / raw)
To: Andrea Corallo; +Cc: leungbk, mattias.engdegard, 63674
> Cc: Brian Leung <leungbk@posteo.net>, 63674@debbugs.gnu.org
> From: Andrea Corallo <akrl@sdf.org>
> Date: Wed, 24 May 2023 13:18:34 +0000
>
> Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>
> >> After the latest changes to native compilation, I see a failure here:
> >> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
> >
> > CC:ing Andrea.
>
> Thanks, will look at as soon as I can.
>
> PS I merged 63679 63679 63681 as I believe are the same.
Your merge didn't succeed, it seems.
And people are still complaining about problems with package.el that
seem to be related to native compilation. So could you please look
into those other issues (bug#63742, bug#63710)?
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-27 6:41 ` Eli Zaretskii
@ 2023-05-28 8:31 ` Andrea Corallo
2023-05-28 10:42 ` Andrea Corallo
1 sibling, 0 replies; 10+ messages in thread
From: Andrea Corallo @ 2023-05-28 8:31 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: leungbk, mattias.engdegard, 63674
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: Brian Leung <leungbk@posteo.net>, 63674@debbugs.gnu.org
>> From: Andrea Corallo <akrl@sdf.org>
>> Date: Wed, 24 May 2023 13:18:34 +0000
>>
>> Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>>
>> >> After the latest changes to native compilation, I see a failure here:
>> >> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
>> >
>> > CC:ing Andrea.
>>
>> Thanks, will look at as soon as I can.
>>
>> PS I merged 63679 63679 63681 as I believe are the same.
>
> Your merge didn't succeed, it seems.
That's strange I think I got the message confirming that.
> And people are still complaining about problems with package.el that
> seem to be related to native compilation. So could you please look
> into those other issues (bug#63742, bug#63710)?
Sure, I did already some work on that and today is dedicated to this
bug.
BR
Andrea
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-27 6:41 ` Eli Zaretskii
2023-05-28 8:31 ` Andrea Corallo
@ 2023-05-28 10:42 ` Andrea Corallo
2023-05-28 12:39 ` Eli Zaretskii
1 sibling, 1 reply; 10+ messages in thread
From: Andrea Corallo @ 2023-05-28 10:42 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: leungbk, mattias.engdegard, 63674
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: Brian Leung <leungbk@posteo.net>, 63674@debbugs.gnu.org
>> From: Andrea Corallo <akrl@sdf.org>
>> Date: Wed, 24 May 2023 13:18:34 +0000
>>
>> Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>>
>> >> After the latest changes to native compilation, I see a failure here:
>> >> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
>> >
>> > CC:ing Andrea.
>>
>> Thanks, will look at as soon as I can.
>>
>> PS I merged 63679 63679 63681 as I believe are the same.
>
> Your merge didn't succeed, it seems.
Ah this is the mail I've got back form debbugs:
=====
Processing commands for control@debbugs.gnu.org:
> merge 63679 63679 63681
bug#63679: 30.0.50; package-delete: native-compile warning on startup
bug#63681: build error from native-comp: void function ("emacs-lisp/package.el" package-desc-p)
Merged 63679 63681.
>
End of message, stopping processing here.
Please contact help-debbugs@gnu.org if you need assistance.
GNU bugs database, https://debbugs.gnu.org/
=====
Not sure why it didn't work then, I assumed it did but maybe I read this
wrong.
Thanks
Andrea
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#63674: 30.0.50; Possible miscompilation of cl-structs?
2023-05-28 10:42 ` Andrea Corallo
@ 2023-05-28 12:39 ` Eli Zaretskii
0 siblings, 0 replies; 10+ messages in thread
From: Eli Zaretskii @ 2023-05-28 12:39 UTC (permalink / raw)
To: Andrea Corallo; +Cc: leungbk, mattias.engdegard, 63674
> From: Andrea Corallo <akrl@sdf.org>
> Cc: mattias.engdegard@gmail.com, leungbk@posteo.net, 63674@debbugs.gnu.org
> Date: Sun, 28 May 2023 10:42:15 +0000
>
> Not sure why it didn't work then, I assumed it did but maybe I read this
> wrong.
Or maybe I was confused regarding which bugs we were talking about.
Never mind, the important thing is that now all the related bugs are
merged.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-05-28 12:39 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-24 3:48 bug#63674: 30.0.50; Possible miscompilation of cl-structs? Brian Leung
2023-05-24 10:09 ` Mattias Engdegård
2023-05-24 10:39 ` Brian Leung
2023-05-25 0:09 ` Brian Leung
2023-05-24 13:18 ` Andrea Corallo
2023-05-24 15:27 ` Andrea Corallo
2023-05-27 6:41 ` Eli Zaretskii
2023-05-28 8:31 ` Andrea Corallo
2023-05-28 10:42 ` Andrea Corallo
2023-05-28 12:39 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).