From: Eli Zaretskii <eliz@gnu.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 25107@debbugs.gnu.org
Subject: bug#25107: Acknowledgement (Patches to clean up ispell.el)
Date: Tue, 06 Dec 2016 17:51:05 +0200 [thread overview]
Message-ID: <8360mxjbti.fsf@gnu.org> (raw)
In-Reply-To: <CAOnWdohG3URpmd9m5SsBRwvkVScCARFWVei7X4zUqk46oZnUdg@mail.gmail.com> (message from Reuben Thomas on Mon, 5 Dec 2016 21:38:16 +0000)
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Mon, 5 Dec 2016 21:38:16 +0000
>
> Attached, an updated patch set which fixes a couple of bugs I found, and adds one more patch to remove an
> unused variable.
Thanks, I have a few comments:
> From b2311cf687ec0af8da1c1c4df46255ebbd334e66 Mon Sep 17 00:00:00 2001
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Sun, 4 Dec 2016 13:55:31 +0000
> Subject: [PATCH 06/23] Generalise over-specific documentation
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * lisp/textmodes/ispell.el (ispell-personal-dictionary): Rather than
> document precise personal wordlist filenames for only two supported
> spelling checkers, simply say that the default personal dictionary
> depends on the chosen spelling checker. The user can check the
> spelling checker’s documentation if necessary. This is simpler, and
> works for other supported (and future, or unknown) spelling checkers.
Why is it useful to remove this information? The documentation of the
spell-checkers themselves leaves a lot to be desired, so asking the
users to go consult it might not be appreciated. I'd rather add here
the missing info about the other spellers.
> From 01e9de80ebf42180a63f8021f754820334cc1fa1 Mon Sep 17 00:00:00 2001
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Sun, 4 Dec 2016 21:58:00 +0000
> Subject: [PATCH 20/23] Remove meaningless defconst ispell-version
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * lisp/textmodes/ispell.el (ispell-version): Since ispell.el is now
> firmly part of Emacs, and the version hasn’t changed since 2003, and
> isn’t used anywhere, remove it. 3rd-party code can better use the
> Emacs version, or feature or function checks.
I agree, but instead of removing the information, how about replacing
it with the Emacs version? Something like "ispell.el from Emacs %s".
The rest of the patch is fine with me. Please wait for a few more
days before pushing, to give people time to comment.
next prev parent reply other threads:[~2016-12-06 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 17:10 bug#25107: Patches to clean up ispell.el Reuben Thomas
[not found] ` <handler.25107.B.148087148014808.ack@debbugs.gnu.org>
2016-12-04 22:11 ` bug#25107: Acknowledgement (Patches to clean up ispell.el) Reuben Thomas
2016-12-05 21:38 ` Reuben Thomas
2016-12-06 15:51 ` Eli Zaretskii [this message]
2016-12-06 16:20 ` Reuben Thomas
2016-12-06 16:37 ` Eli Zaretskii
2016-12-06 17:46 ` Reuben Thomas
2016-12-06 18:01 ` Eli Zaretskii
2016-12-06 18:11 ` Reuben Thomas
2016-12-06 18:41 ` Eli Zaretskii
2016-12-06 21:58 ` Reuben Thomas
2016-12-13 0:55 ` Reuben Thomas
2016-12-13 16:29 ` Eli Zaretskii
2016-12-13 19:07 ` Reuben Thomas
2016-12-13 19:29 ` Eli Zaretskii
2016-12-13 19:45 ` Reuben Thomas
2016-12-13 19:45 ` bug#25107: Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8360mxjbti.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25107@debbugs.gnu.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).