From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25107: Acknowledgement (Patches to clean up ispell.el) Date: Tue, 06 Dec 2016 17:51:05 +0200 Message-ID: <8360mxjbti.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1481039478 21312 195.159.176.226 (6 Dec 2016 15:51:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Dec 2016 15:51:18 +0000 (UTC) Cc: 25107@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 06 16:51:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEI1Q-0004X2-Sr for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Dec 2016 16:51:12 +0100 Original-Received: from localhost ([::1]:32913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEI1U-0002lL-LL for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Dec 2016 10:51:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEI1K-0002kN-MU for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2016 10:51:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEI1G-00060G-Sp for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2016 10:51:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cEI1G-0005zs-PV for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2016 10:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cEI1G-0000IA-H7 for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2016 10:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Dec 2016 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25107 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25107-submit@debbugs.gnu.org id=B25107.14810394561109 (code B ref 25107); Tue, 06 Dec 2016 15:51:02 +0000 Original-Received: (at 25107) by debbugs.gnu.org; 6 Dec 2016 15:50:56 +0000 Original-Received: from localhost ([127.0.0.1]:58403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEI1A-0000Hp-3f for submit@debbugs.gnu.org; Tue, 06 Dec 2016 10:50:56 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEI18-0000Ha-4P for 25107@debbugs.gnu.org; Tue, 06 Dec 2016 10:50:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEI0z-0005xX-Vz for 25107@debbugs.gnu.org; Tue, 06 Dec 2016 10:50:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEI0z-0005xP-SM; Tue, 06 Dec 2016 10:50:45 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4544 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cEI0z-0004QG-3j; Tue, 06 Dec 2016 10:50:45 -0500 In-reply-to: (message from Reuben Thomas on Mon, 5 Dec 2016 21:38:16 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126558 Archived-At: > From: Reuben Thomas > Date: Mon, 5 Dec 2016 21:38:16 +0000 > > ​Attached, ​an updated patch set which fixes a couple of bugs I found, and adds one more patch to remove an > unused variable. Thanks, I have a few comments: > From b2311cf687ec0af8da1c1c4df46255ebbd334e66 Mon Sep 17 00:00:00 2001 > From: Reuben Thomas > Date: Sun, 4 Dec 2016 13:55:31 +0000 > Subject: [PATCH 06/23] Generalise over-specific documentation > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > * lisp/textmodes/ispell.el (ispell-personal-dictionary): Rather than > document precise personal wordlist filenames for only two supported > spelling checkers, simply say that the default personal dictionary > depends on the chosen spelling checker. The user can check the > spelling checker’s documentation if necessary. This is simpler, and > works for other supported (and future, or unknown) spelling checkers. Why is it useful to remove this information? The documentation of the spell-checkers themselves leaves a lot to be desired, so asking the users to go consult it might not be appreciated. I'd rather add here the missing info about the other spellers. > From 01e9de80ebf42180a63f8021f754820334cc1fa1 Mon Sep 17 00:00:00 2001 > From: Reuben Thomas > Date: Sun, 4 Dec 2016 21:58:00 +0000 > Subject: [PATCH 20/23] Remove meaningless defconst ispell-version > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > * lisp/textmodes/ispell.el (ispell-version): Since ispell.el is now > firmly part of Emacs, and the version hasn’t changed since 2003, and > isn’t used anywhere, remove it. 3rd-party code can better use the > Emacs version, or feature or function checks. I agree, but instead of removing the information, how about replacing it with the Emacs version? Something like "ispell.el from Emacs %s". The rest of the patch is fine with me. Please wait for a few more days before pushing, to give people time to comment.