unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#28097: 26.0.50; Commit 9746058 breaks build on MS-Windows
@ 2017-08-15 14:45 Chris Zheng
  2017-08-15 16:19 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Zheng @ 2017-08-15 14:45 UTC (permalink / raw)
  To: 28097


The error message is

fileio.c: In function 'Frename_file':
fileio.c:2300:41: error: duplicate case value
  case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP:
                                         ^~~~
fileio.c:2300:28: note: previously used here
  case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP:
                            ^~~~

Because the file nt/inc/ms-w32.h, line 389, has the definition
“#define ENOTSUP ENOSYS” and it is included early than errno.h
which has the right define. One possible fix is is

@@ -2297,7 +2297,10 @@ This is what happens in interactive use with M-x.  */)
       rename_errno = errno;
       switch (rename_errno)
 	{
-	case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP:
+	case EEXIST: case EINVAL: case ENOSYS:
+#ifdef DARWIN_OS
+	case ENOTSUP:
+#endif
 	  barf_or_query_if_file_exists (newname, rename_errno == EEXIST,
 					"rename to it",
 					INTEGERP (ok_if_already_exists),

Or we can change the #define in ms-w32.h.

Could you please have a look on it?

Thank you,
Chris






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#28097: 26.0.50; Commit 9746058 breaks build on MS-Windows
  2017-08-15 14:45 bug#28097: 26.0.50; Commit 9746058 breaks build on MS-Windows Chris Zheng
@ 2017-08-15 16:19 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2017-08-15 16:19 UTC (permalink / raw)
  To: Chris Zheng; +Cc: 28097-done

> Date: Tue, 15 Aug 2017 22:45:06 +0800
> From: Chris Zheng <chriszheng99@gmail.com>
> 
> 
> The error message is
> 
> fileio.c: In function 'Frename_file':
> fileio.c:2300:41: error: duplicate case value
>   case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP:
>                                          ^~~~
> fileio.c:2300:28: note: previously used here
>   case EEXIST: case EINVAL: case ENOSYS: case ENOTSUP:
>                             ^~~~

Thanks, should be fixed now.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-15 16:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-15 14:45 bug#28097: 26.0.50; Commit 9746058 breaks build on MS-Windows Chris Zheng
2017-08-15 16:19 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).