From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: p.stephani2@gmail.com, 64459@debbugs.gnu.org
Subject: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms
Date: Wed, 05 Jul 2023 16:35:01 +0300 [thread overview]
Message-ID: <835y6yjxbu.fsf@gnu.org> (raw)
In-Reply-To: <jwv35221qgd.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Wed, 05 Jul 2023 08:43:15 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Philipp Stephani <p.stephani2@gmail.com>, 64459@debbugs.gnu.org
> Date: Wed, 05 Jul 2023 08:43:15 -0400
>
> >> > > diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el
> >> > > index d610fa005cc..002a24af18b 100644
> >> > > --- a/lisp/emacs-lisp/syntax.el
> >> > > +++ b/lisp/emacs-lisp/syntax.el
> >> > > @@ -249,11 +249,12 @@ syntax-propertize-rules
> >> > > Note: There may be at most nine back-references in the REGEXPs of
> >> > > all RULES in total."
> >> > > (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step.
> >> > > - (form &rest
> >> > > - (numberp
> >> > > - [&or stringp ;FIXME: Use &wrap
> >> > > - ("prog1" [&or stringp def-form] def-body)
> >> > > - def-form])))))
> >> > > + (def-form
> >> > > + &rest
> >> > > + (numberp
> >> > > + [&or stringp ;FIXME: Use &wrap
> >> > > + ("prog1" [&or stringp form] def-body)
> >> > > + form])))))
> >> > > (let ((newrules nil))
> >> > > (while rules
> >> > > (if (symbolp (car rules))
> >> >
> >> > No, this one introduces a regression. Try that one:
> >> >
> >>
> >> Yeah, that works at least in the cases I've tested. Thanks!
> >
> > Stefan, this is for master, right?
>
> Yes: if you want it for `emacs-29`, I do think it's perfectly safe (it
> just replaces the one `form` with `def-form`), but I don't see any
> urgency here.
I don't see any urgency, either, since this problem existed at least
since Emacs 28.
So please install on master, and thanks.
next prev parent reply other threads:[~2023-07-05 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 13:35 bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms Philipp Stephani
2023-07-04 13:42 ` Eli Zaretskii
2023-07-04 14:06 ` Philipp Stephani
2023-07-04 16:02 ` Eli Zaretskii
2023-07-04 20:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 23:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-05 9:34 ` Philipp Stephani
2023-07-05 11:33 ` Eli Zaretskii
2023-07-05 12:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-05 13:35 ` Eli Zaretskii [this message]
2023-07-05 15:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y6yjxbu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64459@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).