From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms Date: Wed, 05 Jul 2023 16:35:01 +0300 Message-ID: <835y6yjxbu.fsf@gnu.org> References: <83ilayk2yz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: p.stephani2@gmail.com, 64459@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 05 15:36:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qH2gF-0007aR-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jul 2023 15:36:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qH2ft-0002lU-P1; Wed, 05 Jul 2023 09:36:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH2fr-0002k8-TO for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 09:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qH2fr-0002sn-JY for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 09:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qH2fq-0006e9-H0 for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 09:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jul 2023 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64459 X-GNU-PR-Package: emacs Original-Received: via spool by 64459-submit@debbugs.gnu.org id=B64459.168856411325462 (code B ref 64459); Wed, 05 Jul 2023 13:36:02 +0000 Original-Received: (at 64459) by debbugs.gnu.org; 5 Jul 2023 13:35:13 +0000 Original-Received: from localhost ([127.0.0.1]:37960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH2f3-0006cb-5K for submit@debbugs.gnu.org; Wed, 05 Jul 2023 09:35:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH2f0-0006cN-H4 for 64459@debbugs.gnu.org; Wed, 05 Jul 2023 09:35:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH2eu-0002ft-DK; Wed, 05 Jul 2023 09:35:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QsMwx33G3F8w6lRhuBaoMPBSgl9VkNYbrXArAM0WDqE=; b=P8mqaWU0kUKs Kw6EhyTihvIHhaN/Q9P/2l6kWDxvo8tQcCaKXNNzVqSIo50xk/Xzn3+I+Fa8onqvRamg6KJchNo2m wzGhH4f+2MAq1w1EcgPd+hrcEm89GYXS4S19CYKPTe6F4RRw9KkeC1QaClg5lTPDhmzw3eZke2Ate vnq7kBP7TFmByXIih4sswx+PTfBdMWLv/NmfARfq7x1auiy/9dKRu6GxoF9ax9ejdVNGKLp0glRRv CWW2jCOk2qTZ4mFSB0zQIF+8SqdL5T3fQC8BaWVW5M5bLxmEu7bsYE4tBQ378k9D308Y8B/0OblLt s/z8xT1B1vVQlVAowyF+8A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH2es-0006oJ-AM; Wed, 05 Jul 2023 09:35:03 -0400 In-Reply-To: (message from Stefan Monnier on Wed, 05 Jul 2023 08:43:15 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264632 Archived-At: > From: Stefan Monnier > Cc: Philipp Stephani , 64459@debbugs.gnu.org > Date: Wed, 05 Jul 2023 08:43:15 -0400 > > >> > > diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el > >> > > index d610fa005cc..002a24af18b 100644 > >> > > --- a/lisp/emacs-lisp/syntax.el > >> > > +++ b/lisp/emacs-lisp/syntax.el > >> > > @@ -249,11 +249,12 @@ syntax-propertize-rules > >> > > Note: There may be at most nine back-references in the REGEXPs of > >> > > all RULES in total." > >> > > (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. > >> > > - (form &rest > >> > > - (numberp > >> > > - [&or stringp ;FIXME: Use &wrap > >> > > - ("prog1" [&or stringp def-form] def-body) > >> > > - def-form]))))) > >> > > + (def-form > >> > > + &rest > >> > > + (numberp > >> > > + [&or stringp ;FIXME: Use &wrap > >> > > + ("prog1" [&or stringp form] def-body) > >> > > + form]))))) > >> > > (let ((newrules nil)) > >> > > (while rules > >> > > (if (symbolp (car rules)) > >> > > >> > No, this one introduces a regression. Try that one: > >> > > >> > >> Yeah, that works at least in the cases I've tested. Thanks! > > > > Stefan, this is for master, right? > > Yes: if you want it for `emacs-29`, I do think it's perfectly safe (it > just replaces the one `form` with `def-form`), but I don't see any > urgency here. I don't see any urgency, either, since this problem existed at least since Emacs 28. So please install on master, and thanks.