From: Eli Zaretskii <eliz@gnu.org>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: 66546@debbugs.gnu.org
Subject: bug#66546: 30.0.50; save-buffer to write-protected file without backup fails
Date: Fri, 20 Oct 2023 09:06:35 +0300 [thread overview]
Message-ID: <835y31u8t0.fsf@gnu.org> (raw)
In-Reply-To: <87zg0ez57o.fsf@sappc2.fritz.box> (message from Jens Schmidt on Thu, 19 Oct 2023 23:12:59 +0200)
> From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
> Cc: 66546@debbugs.gnu.org
> Date: Thu, 19 Oct 2023 23:12:59 +0200
>
> But probably it would be helpful to shortcut that look-up process, like
> this:
>
> @@ -5946,7 +5949,9 @@ basic-save-buffer-2
> (file-extended-attributes buffer-file-name))
> buffer-file-name))
> ;; If set-file-extended-attributes fails to make the
> - ;; file writable, fall back on set-file-modes.
> + ;; file writable, fall back on set-file-modes. Calling
> + ;; set-file-extended-attributes here may or may not be
> + ;; actually necessary, for details see Bug#66546.
> (with-demoted-errors "Error setting attributes: %s"
> (set-file-extended-attributes buffer-file-name
> (nth 1 setmodes)))
I don't object, though a more detailed explanation (instead of sending
people to read the bug discussion) would be better.
> + ;; If we get an error writing the file which we
> + ;; previously made writable, attempt to undo the
> + ;; write-access.
> + ((and (eq tempsetmodes 'u+w) (not success))
Isn't it easier, safer, and more portable to compare buffer-file-name
with (nth 2 setmodes) instead?
> + (condition-case ()
> + (unless
> + (with-demoted-errors "Error setting file modes: %S"
> + (set-file-modes buffer-file-name (car setmodes)))
> + (set-file-extended-attributes buffer-file-name
> + (nth 1 setmodes)))
> + (error nil)))
Why do we need condition-case here if we use with-demoted-errors?
> I also attached a slightly unrelated, minor doc fix I came across
> when working on this bug.
Thanks, installed on the emacs-29 branch (with minor changes in the
commit log message).
next prev parent reply other threads:[~2023-10-20 6:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 19:09 bug#66546: 30.0.50; save-buffer to write-protected file without backup fails Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-14 19:32 ` Eli Zaretskii
2023-10-14 20:31 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15 5:33 ` Eli Zaretskii
2023-10-15 9:34 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15 9:54 ` Eli Zaretskii
2023-10-15 11:39 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15 12:12 ` Eli Zaretskii
2023-10-15 18:59 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-16 11:19 ` Eli Zaretskii
2023-10-16 20:04 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-17 10:48 ` Eli Zaretskii
2023-10-17 20:12 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-18 11:32 ` Eli Zaretskii
2023-10-18 20:36 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-19 4:40 ` Eli Zaretskii
2023-10-19 21:12 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-20 6:06 ` Eli Zaretskii [this message]
2023-10-21 17:56 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 19:02 ` Eli Zaretskii
2023-10-21 20:17 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22 4:57 ` Eli Zaretskii
2023-10-22 9:45 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-25 12:58 ` Eli Zaretskii
2023-10-29 14:23 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-29 14:39 ` Eli Zaretskii
2023-11-01 19:06 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-02 6:47 ` Eli Zaretskii
2023-11-03 21:02 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 8:58 ` Eli Zaretskii
2023-11-04 12:30 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 12:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y31u8t0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66546@debbugs.gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).