bug#23634: 25.0.90; Eldoc displays incorrect information when parameters contain question marks

bug#23634: 25.0.90; Eldoc displays incorrect information when parameters contain question marks

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 3061 bytes --]

In emacs -Q, placing the point as indicated below causes eldoc to display “a: (X\=\?)” instead of “a: (X?)”.

    (defun a (x?)) ;; Eval this
    (a) ;; <-- place point before parens

This “\=” looks like the escape sequence that we use in docstrings; maybe that's a sign of something?

Clément.

In GNU Emacs 25.0.90.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-02-23 built on clem-w50-mint
Repository revision: f1dc3dc63ae4e454ca0e98eebbd80f0ba9d5c356
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:	Linux Mint 17.3 Rosa

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LC_TIME: en_DK.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec epg epg-config gnus-util mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase
cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
dbusbind inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 89126 5524)
 (symbols 48 20090 0)
 (miscs 40 585 135)
 (strings 32 15127 4930)
 (string-bytes 1 448853)
 (vectors 16 12288)
 (vector-slots 8 439890 5399)
 (floats 8 164 9)
 (intervals 56 190 1)
 (buffers 976 11)
 (heap 1024 35729 924))


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

bug#23634: 25.0.90; Eldoc displays incorrect information when parameters contain question marks

[Dmitry Gutov]

On 05/28/2016 12:22 AM, Clément Pit--Claudel wrote:
> In emacs -Q, placing the point as indicated below causes eldoc to display “a: (X\=\?)” instead of “a: (X?)”.
>
>     (defun a (x?)) ;; Eval this
>     (a) ;; <-- place point before parens
>
> This “\=” looks like the escape sequence that we use in docstrings; maybe that's a sign of something?

Thanks for the report. This is a regression against 24.5.

Eli, do we make it a blocker?

bug#23634: 25.0.90; Eldoc displays incorrect information when parameters contain question marks

[Eli Zaretskii]

> Cc: Eli Zaretskii <eliz@gnu.org>
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sat, 28 May 2016 00:42:35 +0300
> 
> On 05/28/2016 12:22 AM, Clément Pit--Claudel wrote:
> > In emacs -Q, placing the point as indicated below causes eldoc to display “a: (X\=\?)” instead of “a: (X?)”.
> >
> >     (defun a (x?)) ;; Eval this
> >     (a) ;; <-- place point before parens
> >
> > This “\=” looks like the escape sequence that we use in docstrings; maybe that's a sign of something?
> 
> Thanks for the report. This is a regression against 24.5.

Indeed, it is.

> Eli, do we make it a blocker?

I don't think so.  It sounds like a marginal use case that's easy to
avoid (this isn't Scheme, so predicates should be named SOMETHING-p,
not SOMETHING?).  But if someone wants to make a case why it should be
blocking, I'm all ears.

I also think that if a simple solution exists, we should fix this on
the release branch.

Thanks.

bug#23634: 25.0.90; Eldoc displays incorrect information when parameters contain question marks

[Andreas Schwab]

Eli Zaretskii <eliz@gnu.org> writes:

> I also think that if a simple solution exists, we should fix this on
> the release branch.

It was trivial to fix, so I just did.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#23634: 25.0.90; Eldoc displays incorrect information when parameters contain question marks

[Eli Zaretskii]

> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
> 	autolearn=disabled version=3.3.2
> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Dmitry Gutov <dgutov@yandex.ru>,  clement.pitclaudel@live.com,  23634-done@debbugs.gnu.org
> Date: Sat, 28 May 2016 11:19:40 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I also think that if a simple solution exists, we should fix this on
> > the release branch.
> 
> It was trivial to fix, so I just did.

Thanks!