From: Eli Zaretskii <eliz@gnu.org>
To: Hong Xu <hong@topbug.net>
Cc: 25086-done@debbugs.gnu.org
Subject: bug#25086: [PATCH] Fix the timezone detection of parse-iso8601-time-string.
Date: Sat, 24 Dec 2016 14:41:09 +0200 [thread overview]
Message-ID: <834m1tzehm.fsf@gnu.org> (raw)
In-Reply-To: <87d1gqlym9.fsf@topbug.net> (message from Hong Xu on Sat, 17 Dec 2016 19:11:58 -0800)
> From: Hong Xu <hong@topbug.net>
> Cc: 25086@debbugs.gnu.org
> Date: Sat, 17 Dec 2016 19:11:58 -0800
>
> On 2016-12-17 Sat 12:42 GMT-0800, Hong Xu <hong@topbug.net> wrote:
> >
> > I've added the tests now. And indeed, it exposes a bug in the original patch.
> >
> > Again, I decomposed the patch to two different parts, one for the stable
> > branch and the other (with only test files) for the master branch.
>
> Attached is a newer version which has fixed a few edge cases.
Thanks, pushed to master.
I didn't make parse-iso8601-time-string autoloaded. I don't think
it's needed; if you think it is, please tell why.
Also, a minor not about log messages:
> * parse-time.el (parse-iso8601-time-string): Fix its timezone
> parsing and make it autoload.
> * parse-time.el: Add doc for parse-iso8601-time-string.
These are changes in the same function and the same source file. So
they should be written together, like this:
* parse-time.el (parse-iso8601-time-string): Fix timezone
parsing. Add a doc string.
Thank you for your contribution and for your patience.
next prev parent reply other threads:[~2016-12-24 12:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 3:46 bug#25086: [PATCH] Fix the timezone detection of parse-iso8601-time-string Hong Xu
2016-12-02 3:55 ` Hong Xu
2016-12-02 4:04 ` Hong Xu
[not found] ` <qf5fum6ubn4.fsf@marmstrong-macbookpro.roam.corp.google.com>
2016-12-02 6:13 ` Hong Xu
2016-12-12 0:37 ` Hong Xu
2016-12-12 17:22 ` Matt Armstrong
2016-12-12 17:58 ` Eli Zaretskii
2016-12-17 14:58 ` Eli Zaretskii
2016-12-17 20:42 ` Hong Xu
2016-12-18 3:11 ` Hong Xu
2016-12-24 12:41 ` Eli Zaretskii [this message]
2016-12-24 21:04 ` Hong Xu
2016-12-25 3:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834m1tzehm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25086-done@debbugs.gnu.org \
--cc=hong@topbug.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).