From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25086: [PATCH] Fix the timezone detection of parse-iso8601-time-string. Date: Sat, 24 Dec 2016 14:41:09 +0200 Message-ID: <834m1tzehm.fsf@gnu.org> References: <1480650408-26252-1-git-send-email-hong@topbug.net> <874m2nyog6.fsf@topbug.net> <8737i7yo27.fsf@topbug.net> <837f6y7gch.fsf@gnu.org> <87eg16z3qm.fsf@topbug.net> <87d1gqlym9.fsf@topbug.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1482583340 20480 195.159.176.226 (24 Dec 2016 12:42:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Dec 2016 12:42:20 +0000 (UTC) Cc: 25086-done@debbugs.gnu.org To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 24 13:42:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKleL-0003uS-TJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Dec 2016 13:42:10 +0100 Original-Received: from localhost ([::1]:43280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKleO-0004ji-Sz for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Dec 2016 07:42:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKleI-0004ig-Jg for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 07:42:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKleE-0007UW-O2 for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 07:42:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKleE-0007UI-Km for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 07:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKleE-0002iN-G7 for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 07:42:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Dec 2016 12:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25086 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 25086@debbugs.gnu.org, eliz@gnu.org, hong@topbug.net Original-Received: via spool by 25086-done@debbugs.gnu.org id=D25086.148258329910398 (code D ref 25086); Sat, 24 Dec 2016 12:42:02 +0000 Original-Received: (at 25086-done) by debbugs.gnu.org; 24 Dec 2016 12:41:39 +0000 Original-Received: from localhost ([127.0.0.1]:53291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKldr-0002hd-8E for submit@debbugs.gnu.org; Sat, 24 Dec 2016 07:41:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKldp-0002hR-P4 for 25086-done@debbugs.gnu.org; Sat, 24 Dec 2016 07:41:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKldg-0007Gv-L8 for 25086-done@debbugs.gnu.org; Sat, 24 Dec 2016 07:41:32 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKldg-0007Gj-Ht; Sat, 24 Dec 2016 07:41:28 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3742 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cKldf-00060D-Si; Sat, 24 Dec 2016 07:41:28 -0500 In-reply-to: <87d1gqlym9.fsf@topbug.net> (message from Hong Xu on Sat, 17 Dec 2016 19:11:58 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127388 Archived-At: > From: Hong Xu > Cc: 25086@debbugs.gnu.org > Date: Sat, 17 Dec 2016 19:11:58 -0800 > > On 2016-12-17 Sat 12:42 GMT-0800, Hong Xu wrote: > > > > I've added the tests now. And indeed, it exposes a bug in the original patch. > > > > Again, I decomposed the patch to two different parts, one for the stable > > branch and the other (with only test files) for the master branch. > > Attached is a newer version which has fixed a few edge cases. Thanks, pushed to master. I didn't make parse-iso8601-time-string autoloaded. I don't think it's needed; if you think it is, please tell why. Also, a minor not about log messages: > * parse-time.el (parse-iso8601-time-string): Fix its timezone > parsing and make it autoload. > * parse-time.el: Add doc for parse-iso8601-time-string. These are changes in the same function and the same source file. So they should be written together, like this: * parse-time.el (parse-iso8601-time-string): Fix timezone parsing. Add a doc string. Thank you for your contribution and for your patience.