From: Eli Zaretskii <eliz@gnu.org>
To: rcopley@gmail.com
Cc: monnier@iro.umontreal.ca, 40661@debbugs.gnu.org
Subject: bug#40661: Crash in regex search during redisplay
Date: Fri, 17 Apr 2020 16:55:44 +0300 [thread overview]
Message-ID: <834kticj33.fsf@gnu.org> (raw)
In-Reply-To: <838siucq7b.fsf@gnu.org> (message from Eli Zaretskii on Fri, 17 Apr 2020 14:22:00 +0300)
> Date: Fri, 17 Apr 2020 14:22:00 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 40661@debbugs.gnu.org
>
> Obviously, we cannot allow GC to run while regex routines do their
> work, because they are passed C pointers to buffer text. The question
> is, where to disable GC? We could do it inside
> update_syntax_table_forward, but UPDATE_SYNTAX_TABLE_FORWARD is called
> from many places that evidently have no problems with GC. So my
> suggestion would be to disable GC inside re_match_2_internal instead.
Alternatively, we could set the buffer's inhibit_shrinking flag while
in re_match_2_internal. Although that flag was introduced for a
different purpose: for when we have stuff inside the gap that we don't
want to lose. The name of the flag notwithstanding, I'm not sure we
want to conflate these two purposes. But maybe it's better than
preventing the GC entirely.
next prev parent reply other threads:[~2020-04-17 13:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 14:35 bug#40661: Crash in regex search during redisplay Richard Copley
2020-04-16 15:36 ` Eli Zaretskii
2020-04-16 16:33 ` Eli Zaretskii
2020-04-16 16:42 ` Daniel Colascione
2020-04-16 16:56 ` Richard Copley
2020-04-16 17:24 ` Daniel Colascione
2020-04-16 19:35 ` Richard Copley
2020-04-17 11:22 ` Eli Zaretskii
2020-04-17 13:55 ` Eli Zaretskii [this message]
2020-04-17 14:01 ` Daniel Colascione
2020-04-17 15:28 ` Stefan Monnier
2020-04-17 15:50 ` Eli Zaretskii
2020-04-17 16:00 ` Stefan Monnier
2020-04-18 11:57 ` Eli Zaretskii
2020-04-20 18:30 ` Richard Copley
2020-04-20 19:06 ` Eli Zaretskii
2020-04-20 23:04 ` Richard Copley
2020-09-30 3:49 ` Lars Ingebrigtsen
2020-04-16 16:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834kticj33.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=40661@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).