From: Eli Zaretskii <eliz@gnu.org>
To: Dmitrii Kuragin <dmitriy.kuragin@gmail.com>
Cc: dkuragin@ya.ru, 48246@debbugs.gnu.org
Subject: bug#48246: [PATCH] Prevent unnecessary restarings of ispell program.
Date: Thu, 06 May 2021 07:57:29 +0300 [thread overview]
Message-ID: <834kfgfohy.fsf@gnu.org> (raw)
In-Reply-To: <20210505202945.32400-1-dmitriy.kuragin@gmail.com> (message from Dmitrii Kuragin on Wed, 5 May 2021 13:29:45 -0700)
> From: Dmitrii Kuragin <dmitriy.kuragin@gmail.com>
> Date: Wed, 5 May 2021 13:29:45 -0700
> Cc: Dmitrii Kuragin <dkuragin@ya.ru>
>
> From: Dmitrii Kuragin <dkuragin@ya.ru>
>
> Fix bug when ispell always restarted when `ispell-program-name` has a
> custom value. Function `eq` compares the object identity and not the
> object values which causes `eq` always return `nil` for values with the
> same value but different identity (address). `equal` compares actual
> values.
Thanks, but if we want to be smart about this, why stop at 'equal'?
why not 'file-equal-p'? The latter will succeed in more cases.
next prev parent reply other threads:[~2021-05-06 4:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 20:29 bug#48246: [PATCH] Prevent unnecessary restarings of ispell program Dmitrii Kuragin
2021-05-06 4:57 ` Eli Zaretskii [this message]
2021-05-06 7:12 ` Andreas Schwab
2021-05-06 7:59 ` Eli Zaretskii
2021-05-06 8:20 ` Andreas Schwab
2021-05-06 9:45 ` Lars Ingebrigtsen
2021-05-06 15:48 ` Dmitrii Kuragin
2021-05-07 8:41 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834kfgfohy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48246@debbugs.gnu.org \
--cc=dkuragin@ya.ru \
--cc=dmitriy.kuragin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).