From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48246: [PATCH] Prevent unnecessary restarings of ispell program. Date: Thu, 06 May 2021 07:57:29 +0300 Message-ID: <834kfgfohy.fsf@gnu.org> References: <20210505202945.32400-1-dmitriy.kuragin@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3785"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dkuragin@ya.ru, 48246@debbugs.gnu.org To: Dmitrii Kuragin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 06:58:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leW5R-0000tl-NU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 06:58:09 +0200 Original-Received: from localhost ([::1]:60628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leW5Q-0007v7-Mm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 00:58:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leW5K-0007v0-B1 for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 00:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leW5K-0004vg-3R for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 00:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leW5K-0000Fj-21 for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 00:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 04:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48246 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48246-submit@debbugs.gnu.org id=B48246.1620277066963 (code B ref 48246); Thu, 06 May 2021 04:58:02 +0000 Original-Received: (at 48246) by debbugs.gnu.org; 6 May 2021 04:57:46 +0000 Original-Received: from localhost ([127.0.0.1]:36650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leW53-0000FT-US for submit@debbugs.gnu.org; Thu, 06 May 2021 00:57:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leW52-0000FN-De for 48246@debbugs.gnu.org; Thu, 06 May 2021 00:57:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40664) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leW4w-0004gv-PZ; Thu, 06 May 2021 00:57:38 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3207 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leW4w-0002S0-B0; Thu, 06 May 2021 00:57:38 -0400 In-Reply-To: <20210505202945.32400-1-dmitriy.kuragin@gmail.com> (message from Dmitrii Kuragin on Wed, 5 May 2021 13:29:45 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205750 Archived-At: > From: Dmitrii Kuragin > Date: Wed, 5 May 2021 13:29:45 -0700 > Cc: Dmitrii Kuragin > > From: Dmitrii Kuragin > > Fix bug when ispell always restarted when `ispell-program-name` has a > custom value. Function `eq` compares the object identity and not the > object values which causes `eq` always return `nil` for values with the > same value but different identity (address). `equal` compares actual > values. Thanks, but if we want to be smart about this, why stop at 'equal'? why not 'file-equal-p'? The latter will succeed in more cases.