From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 57266@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#57266: Maintaining the base_line_number cache
Date: Tue, 23 Aug 2022 18:56:28 +0300 [thread overview]
Message-ID: <834jy37y37.fsf@gnu.org> (raw)
In-Reply-To: <8735dnrqf0.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 23 Aug 2022 16:21:55 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 57266@debbugs.gnu.org
> Date: Tue, 23 Aug 2022 16:21:55 +0200
>
> Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
> > Indeed, my proposed patch is not a bug fix.
> > It's a code-maintenance patch. It's meant to improve the code, not
> > the behavior.
>
> My two cents: I was reading through parts of the newline (cache) code
> last week while I was pondering whether to do the `pos-eol' functions or
> not, and I have to say that I found it pretty impregnable. So in a way
> I'm relieved to learn that it's (partly) because the code doesn't make
> as much sense as it should. 😀
>
> Apparently Eli is the only person that understands the code at present,
> and I understand his reluctance to change something that works. But
> making the code easier to understand would enable more people to
> actually handle the code. So I'm in favour of improving the code.
I'm also in favor of improving the code. I just disagree with Stefan
about what constitutes "improvement" in this case.
I had my share of "TIL" experiences, where I was positive I knew how
the code should work and wrote or changed something accordingly --
only to discover that some of my concepts were completely wrong or
missed some important aspects which wound up invalidating some of the
code I wrote. I don't think I'm alone in that.
Breaking things while fixing real bugs is justified. But this isn't
that case.
prev parent reply other threads:[~2022-08-23 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 21:18 bug#57266: Maintaining the base_line_number cache Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <handler.57266.B.166077115022973.ack@debbugs.gnu.org>
2022-08-17 21:39 ` bug#57266: Acknowledgement (Maintaining the base_line_number cache) Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-18 6:03 ` bug#57266: Maintaining the base_line_number cache Eli Zaretskii
2022-08-22 4:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-22 12:11 ` Eli Zaretskii
2022-08-22 12:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-22 13:07 ` Eli Zaretskii
2022-08-22 13:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-22 16:21 ` Eli Zaretskii
2022-08-22 18:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-22 18:35 ` Eli Zaretskii
2022-08-22 19:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-23 14:21 ` Lars Ingebrigtsen
2022-08-23 14:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-23 15:56 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jy37y37.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=57266@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).