unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#64022: Subject: 28.2; minibuffer-beginning-of-buffer fails to set mark
@ 2023-06-12 15:15 Al Petrofsky
  2023-06-12 15:49 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Al Petrofsky @ 2023-06-12 15:15 UTC (permalink / raw)
  To: 64022

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

   emacs -Q
   M-: foo M-< C-x C-x

In emacs 26, point returns to the end of the minibuffer, but in 27 and
28.2 a bogus "No mark set in this buffer" error is reported.

I think the first 'when' in minibuffer-beginning-of-buffer is supposed
to be 'unless'.

Another issue is that this:

   emacs -Q
   M-: C-x C-x

correctly reports "No mark set in this buffer", but this:

   emacs -Q
   M-: t C-@ RET
   M-: C-x C-x

does not.  This does no harm, but logically the mark should probably
be unset when a new minibuffer is created.

[-- Attachment #2: Type: text/html, Size: 676 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#64022: Subject: 28.2; minibuffer-beginning-of-buffer fails to set mark
  2023-06-12 15:15 bug#64022: Subject: 28.2; minibuffer-beginning-of-buffer fails to set mark Al Petrofsky
@ 2023-06-12 15:49 ` Eli Zaretskii
  2023-06-17  7:44   ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2023-06-12 15:49 UTC (permalink / raw)
  To: Al Petrofsky; +Cc: 64022

> From: Al Petrofsky <al@petrofsky.org>
> Date: Mon, 12 Jun 2023 11:15:43 -0400
> 
>    emacs -Q
>    M-: foo M-< C-x C-x
> 
> In emacs 26, point returns to the end of the minibuffer, but in 27 and
> 28.2 a bogus "No mark set in this buffer" error is reported.
> 
> I think the first 'when' in minibuffer-beginning-of-buffer is supposed
> to be 'unless'.

You are right.  I've now fixed this on the emacs-29 branch.

> Another issue is that this:
> 
>    emacs -Q
>    M-: C-x C-x
> 
> correctly reports "No mark set in this buffer", but this:
> 
>    emacs -Q
>    M-: t C-@ RET
>    M-: C-x C-x
> 
> does not.  This does no harm, but logically the mark should probably
> be unset when a new minibuffer is created.

It's not a new minibuffer, it's the same "*Minibuf-1*" minibuffer used
the first time.  So I think Emacs behaves correctly here.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#64022: Subject: 28.2; minibuffer-beginning-of-buffer fails to set mark
  2023-06-12 15:49 ` Eli Zaretskii
@ 2023-06-17  7:44   ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-06-17  7:44 UTC (permalink / raw)
  To: al; +Cc: 64022-done

> Cc: 64022@debbugs.gnu.org
> Date: Mon, 12 Jun 2023 18:49:30 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Al Petrofsky <al@petrofsky.org>
> > Date: Mon, 12 Jun 2023 11:15:43 -0400
> > 
> >    emacs -Q
> >    M-: foo M-< C-x C-x
> > 
> > In emacs 26, point returns to the end of the minibuffer, but in 27 and
> > 28.2 a bogus "No mark set in this buffer" error is reported.
> > 
> > I think the first 'when' in minibuffer-beginning-of-buffer is supposed
> > to be 'unless'.
> 
> You are right.  I've now fixed this on the emacs-29 branch.

No further comments, so I'm now closing this bug.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-17  7:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 15:15 bug#64022: Subject: 28.2; minibuffer-beginning-of-buffer fails to set mark Al Petrofsky
2023-06-12 15:49 ` Eli Zaretskii
2023-06-17  7:44   ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).