From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: felix.dietrich@sperrhaken.name, luangruo@yahoo.com,
larsi@gnus.org, 58312@debbugs.gnu.org
Subject: bug#58312: Improve “Invalid face attribute” error message
Date: Wed, 10 Jan 2024 15:38:00 +0200 [thread overview]
Message-ID: <834jflnwav.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkc+0RRb8ZR6PD_dSYwCu6oG_wCiZXZzYoEujyq=HB=xw@mail.gmail.com> (message from Stefan Kangas on Wed, 10 Jan 2024 02:50:46 -0800)
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Wed, 10 Jan 2024 02:50:46 -0800
> Cc: Felix Dietrich <felix.dietrich@sperrhaken.name>, 58312@debbugs.gnu.org, eliz@gnu.org,
> Po Lu <luangruo@yahoo.com>
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > Felix Dietrich <felix.dietrich@sperrhaken.name> writes:
> >
> >> Could the log message “Invalid face attribute” created by
> >> “xfaces.c:merge_face_ref” be extended to also include the buffer or
> >> other identifying information about its origin?
> >
> > Perhaps include the window name? That would be less ambiguous than the
> > buffer name.
>
> That makes sense to me. Eli or Po Lu, WDYT about this change?
Patches welcome, but please take into account the fact that the window
is not always known there: merge_face_ref can be called with its first
argument NULL.
prev parent reply other threads:[~2024-01-10 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 18:42 bug#58312: Improve “Invalid face attribute” error message Felix Dietrich
2022-10-06 12:44 ` Lars Ingebrigtsen
2024-01-10 10:50 ` Stefan Kangas
2024-01-10 13:38 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jflnwav.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58312@debbugs.gnu.org \
--cc=felix.dietrich@sperrhaken.name \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).