From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58312: Improve =?UTF-8?Q?=E2=80=9CInvalid?= face =?UTF-8?Q?attribute=E2=80=9D?= error message Date: Wed, 10 Jan 2024 15:38:00 +0200 Message-ID: <834jflnwav.fsf@gnu.org> References: <87czb6p0x7.fsf@sperrhaken.name> <87pmf5xgso.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26648"; mail-complaints-to="usenet@ciao.gmane.io" Cc: felix.dietrich@sperrhaken.name, luangruo@yahoo.com, larsi@gnus.org, 58312@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 14:48:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNYwU-0006f2-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 14:48:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNYw9-0007UF-NU; Wed, 10 Jan 2024 08:48:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNYw7-0007TF-PW for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:48:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNYw7-000442-GP for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:48:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNYw6-00031u-3V for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58312 X-GNU-PR-Package: emacs Original-Received: via spool by 58312-submit@debbugs.gnu.org id=B58312.170489446211463 (code B ref 58312); Wed, 10 Jan 2024 13:48:02 +0000 Original-Received: (at 58312) by debbugs.gnu.org; 10 Jan 2024 13:47:42 +0000 Original-Received: from localhost ([127.0.0.1]:39222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNYvl-0002yc-SP for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:47:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNYvh-0002ww-ND for 58312@debbugs.gnu.org; Wed, 10 Jan 2024 08:47:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNYmi-0007iD-Oe; Wed, 10 Jan 2024 08:38:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=4CweE6fYErviUqekyC6OMON5mpZrVqTP2OXILhmtH58=; b=CYAhjPn0atORvmeNEUUD g+NogoI1UM3MBb6+wd7NEfPABRhEhRGQdtSdgPDffw4RsmAJ1/z9kXGc4nSIIL+8W0kAxe6N1EBnI M2M42QNr8ys1DAY0w+Ft4vqZ/n7i8DD475pC9fAOg1NyHbubNW/BTooPoPBWcU/YMJ6U9BAY69cdj KzTILO95YDNsu4YWEVP3rWg/dzMYSYsXJeqG6lO7ZdBraO6+wk7qQFMspDoT/ok7Tqob3df6/ojes ds+a1Bip7b6G6gPX8kzzx3Fp8LjWV5Xs9cRDIT6MKLtU36wxmNBdWyUYRAnbcCl51VuuU3Q6gB5DY ZQfdPijbh5dklA==; In-Reply-To: (message from Stefan Kangas on Wed, 10 Jan 2024 02:50:46 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277737 Archived-At: > From: Stefan Kangas > Date: Wed, 10 Jan 2024 02:50:46 -0800 > Cc: Felix Dietrich , 58312@debbugs.gnu.org, eliz@gnu.org, > Po Lu > > Lars Ingebrigtsen writes: > > > Felix Dietrich writes: > > > >> Could the log message “Invalid face attribute” created by > >> “xfaces.c:merge_face_ref” be extended to also include the buffer or > >> other identifying information about its origin? > > > > Perhaps include the window name? That would be less ambiguous than the > > buffer name. > > That makes sense to me. Eli or Po Lu, WDYT about this change? Patches welcome, but please take into account the fact that the window is not always known there: merge_face_ref can be called with its first argument NULL.