From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, gavinsmith0123@gmail.com
Subject: bug#32446: Configure-time requirement for gnutls is too old
Date: Tue, 18 Sep 2018 13:28:03 +0300 [thread overview]
Message-ID: <8336u7gkwc.fsf@gnu.org> (raw)
In-Reply-To: <87a7ofr9d2.fsf@gmail.com> (message from Noam Postavsky on Mon, 17 Sep 2018 19:29:29 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, Gavin Smith <gavinsmith0123@gmail.com>
> Date: Mon, 17 Sep 2018 19:29:29 -0400
>
> > I'll push it tomorrow after double checking the updated version on
> > Windows.
>
> > +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME
> > LOAD_DLL_FN (library, gnutls_digest_get_name);
>
> > +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME
> > +# define gnutls_digest_get_name fn_gnutls_digest_get_name
>
> Fixed those two ifdef checks, and pushed to emacs-26.
>
> [1: b5bee6bf48]: 2018-09-17 17:54:32 -0400
> Fix build with gnutls versions 3.0 to 3.2 (Bug#32446)
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b5bee6bf489d8c54a5e39baed4d578ada54c99bf
This caused Emacs with GnuTLS 3.4.15 to crash in the test suite. The
problem is that the test suite avoids trying AEAD-capable ciphers when
AEAD is unavailable, but one of the changes in the above made _all_
ciphers look like not AEAD-capable.
I fixed it by allowing gnutls_cipher_get_tag_size for versions above
3.2.2, as it should at least allow use to continue skipping
AEAD-capable ciphers based on this assumption, and it shouldn't affect
GnuTLS 2.x.
next prev parent reply other threads:[~2018-09-18 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 11:12 bug#32446: Configure-time requirement for gnutls is too old Gavin Smith
2018-08-15 16:09 ` Eli Zaretskii
2018-08-21 2:08 ` Glenn Morris
2018-09-15 14:44 ` Noam Postavsky
2018-09-15 15:26 ` Eli Zaretskii
2018-09-15 15:55 ` Gavin Smith
2018-09-15 16:17 ` Eli Zaretskii
2018-09-16 20:31 ` Noam Postavsky
2018-09-17 23:29 ` Noam Postavsky
2018-09-18 10:28 ` Eli Zaretskii [this message]
2018-09-18 13:14 ` Noam Postavsky
2018-09-18 14:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8336u7gkwc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32446@debbugs.gnu.org \
--cc=gavinsmith0123@gmail.com \
--cc=npostavs@gmail.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).