From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32446: Configure-time requirement for gnutls is too old Date: Tue, 18 Sep 2018 13:28:03 +0300 Message-ID: <8336u7gkwc.fsf@gnu.org> References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> <83musiixxg.fsf@gnu.org> <20180915155509.GA750@darkstar> <83k1nmivll.fsf@gnu.org> <87sh29qj57.fsf@gmail.com> <87a7ofr9d2.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1537266437 20100 195.159.176.226 (18 Sep 2018 10:27:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2018 10:27:17 +0000 (UTC) Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, gavinsmith0123@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 18 12:27:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2DDs-0004yO-Nf for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Sep 2018 12:27:12 +0200 Original-Received: from localhost ([::1]:39468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2DFu-0004RG-2F for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Sep 2018 06:29:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2DFi-0004Qh-Rk for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 06:29:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2DFe-00034q-Op for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 06:29:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2DFe-00034b-JC for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 06:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g2DFe-0003E8-DT for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 06:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Sep 2018 10:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 32446-submit@debbugs.gnu.org id=B32446.153726651912373 (code B ref 32446); Tue, 18 Sep 2018 10:29:02 +0000 Original-Received: (at 32446) by debbugs.gnu.org; 18 Sep 2018 10:28:39 +0000 Original-Received: from localhost ([127.0.0.1]:43658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2DFG-0003DV-TS for submit@debbugs.gnu.org; Tue, 18 Sep 2018 06:28:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2DFC-0003DF-OO for 32446@debbugs.gnu.org; Tue, 18 Sep 2018 06:28:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2DF6-0001j2-CZ for 32446@debbugs.gnu.org; Tue, 18 Sep 2018 06:28:29 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2DEm-00019X-Qo; Tue, 18 Sep 2018 06:28:08 -0400 Original-Received: from [176.228.60.248] (port=4352 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g2DEl-0006YF-MD; Tue, 18 Sep 2018 06:28:08 -0400 In-reply-to: <87a7ofr9d2.fsf@gmail.com> (message from Noam Postavsky on Mon, 17 Sep 2018 19:29:29 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150395 Archived-At: > From: Noam Postavsky > Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, Gavin Smith > Date: Mon, 17 Sep 2018 19:29:29 -0400 > > > I'll push it tomorrow after double checking the updated version on > > Windows. > > > +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME > > LOAD_DLL_FN (library, gnutls_digest_get_name); > > > +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME > > +# define gnutls_digest_get_name fn_gnutls_digest_get_name > > Fixed those two ifdef checks, and pushed to emacs-26. > > [1: b5bee6bf48]: 2018-09-17 17:54:32 -0400 > Fix build with gnutls versions 3.0 to 3.2 (Bug#32446) > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b5bee6bf489d8c54a5e39baed4d578ada54c99bf This caused Emacs with GnuTLS 3.4.15 to crash in the test suite. The problem is that the test suite avoids trying AEAD-capable ciphers when AEAD is unavailable, but one of the changes in the above made _all_ ciphers look like not AEAD-capable. I fixed it by allowing gnutls_cipher_get_tag_size for versions above 3.2.2, as it should at least allow use to continue skipping AEAD-capable ciphers based on this assumption, and it shouldn't affect GnuTLS 2.x.